mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 05:41:13 +00:00
980ebd2d35
No longer check whether key is a symbol as Object.keys does not return symbols. No longer convert key to string as it is always a string. Validate that only one value is passed for each pseudo-header. Extend illegal connection header message to include the name of the problematic header. Extend tests to cover this behaviour. PR-URL: https://github.com/nodejs/node/pull/16575 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
57 lines
1.4 KiB
JavaScript
57 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
|
|
// Check that pushStream handles being passed wrong arguments
|
|
// in the expected manner
|
|
|
|
const server = http2.createServer();
|
|
server.on('stream', common.mustCall((stream, headers) => {
|
|
const port = server.address().port;
|
|
|
|
// Must receive a callback (function)
|
|
common.expectsError(
|
|
() => stream.pushStream({
|
|
':scheme': 'http',
|
|
':path': '/foobar',
|
|
':authority': `localhost:${port}`,
|
|
}, {}, 'callback'),
|
|
{
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
message: 'Callback must be a function'
|
|
}
|
|
);
|
|
|
|
// Must validate headers
|
|
common.expectsError(
|
|
() => stream.pushStream({ 'connection': 'test' }, {}, () => {}),
|
|
{
|
|
code: 'ERR_HTTP2_INVALID_CONNECTION_HEADERS',
|
|
message: 'HTTP/1 Connection specific headers are forbidden: "connection"'
|
|
}
|
|
);
|
|
|
|
stream.end('test');
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const port = server.address().port;
|
|
const headers = { ':path': '/' };
|
|
const client = http2.connect(`http://localhost:${port}`);
|
|
const req = client.request(headers);
|
|
req.setEncoding('utf8');
|
|
|
|
let data = '';
|
|
req.on('data', common.mustCall((d) => data += d));
|
|
req.on('end', common.mustCall(() => {
|
|
assert.strictEqual(data, 'test');
|
|
server.close();
|
|
client.destroy();
|
|
}));
|
|
req.end();
|
|
}));
|