mirror of
https://github.com/nodejs/node.git
synced 2025-05-22 16:07:07 +00:00
b610a4db1c
This commit implements the Web IDL USVString conversion, which mandates all unpaired Unicode surrogates be turned into U+FFFD REPLACEMENT CHARACTER. It also disallows Symbols to be used as USVString per spec. Certain functions call into C++ methods in the binding that use the Utf8Value class to access string arguments. Utf8Value already does the normalization using V8's String::Write, so in those cases, instead of doing the full USVString normalization, only a symbol check is done (`'' + val`, which uses ES's ToString, versus `String()` which has special provisions for symbols). PR-URL: https://github.com/nodejs/node/pull/11436 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
56 lines
2.1 KiB
JavaScript
56 lines
2.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const URLSearchParams = require('url').URLSearchParams;
|
|
const { test, assert_equals, assert_true } = common.WPT;
|
|
|
|
/* eslint-disable */
|
|
/* WPT Refs:
|
|
https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-set.html
|
|
License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html
|
|
*/
|
|
test(function() {
|
|
var params = new URLSearchParams('a=b&c=d');
|
|
params.set('a', 'B');
|
|
assert_equals(params + '', 'a=B&c=d');
|
|
params = new URLSearchParams('a=b&c=d&a=e');
|
|
params.set('a', 'B');
|
|
assert_equals(params + '', 'a=B&c=d')
|
|
params.set('e', 'f');
|
|
assert_equals(params + '', 'a=B&c=d&e=f')
|
|
}, 'Set basics');
|
|
|
|
test(function() {
|
|
var params = new URLSearchParams('a=1&a=2&a=3');
|
|
assert_true(params.has('a'), 'Search params object has name "a"');
|
|
assert_equals(params.get('a'), '1', 'Search params object has name "a" with value "1"');
|
|
params.set('first', 4);
|
|
assert_true(params.has('a'), 'Search params object has name "a"');
|
|
assert_equals(params.get('a'), '1', 'Search params object has name "a" with value "1"');
|
|
params.set('a', 4);
|
|
assert_true(params.has('a'), 'Search params object has name "a"');
|
|
assert_equals(params.get('a'), '4', 'Search params object has name "a" with value "4"');
|
|
}, 'URLSearchParams.set');
|
|
/* eslint-enable */
|
|
|
|
// Tests below are not from WPT.
|
|
{
|
|
const params = new URLSearchParams();
|
|
assert.throws(() => {
|
|
params.set.call(undefined);
|
|
}, /^TypeError: Value of `this` is not a URLSearchParams$/);
|
|
assert.throws(() => {
|
|
params.set('a');
|
|
}, /^TypeError: "name" and "value" arguments must be specified$/);
|
|
|
|
const obj = { toString() { throw new Error('toString'); } };
|
|
const sym = Symbol();
|
|
assert.throws(() => params.append(obj, 'b'), /^Error: toString$/);
|
|
assert.throws(() => params.append('a', obj), /^Error: toString$/);
|
|
assert.throws(() => params.append(sym, 'b'),
|
|
/^TypeError: Cannot convert a Symbol value to a string$/);
|
|
assert.throws(() => params.append('a', sym),
|
|
/^TypeError: Cannot convert a Symbol value to a string$/);
|
|
}
|