mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 03:31:35 +00:00
3da44b0b52
Re: https://github.com/nodejs/node/pull/27945#discussion_r288833979 This commit regards reporting to the JS level an actual event that happens when using suspected improper null arguments. It is better to report the exact reason from N-API to the JS level. PR-URL: https://github.com/nodejs/node/pull/28505 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
63 lines
2.4 KiB
JavaScript
63 lines
2.4 KiB
JavaScript
'use strict';
|
|
const common = require('../../common');
|
|
const assert = require('assert');
|
|
|
|
const getterOnlyErrorRE =
|
|
/^TypeError: Cannot set property .* of #<.*> which has only a getter$/;
|
|
|
|
// Testing api calls for a constructor that defines properties
|
|
const TestConstructor = require(`./build/${common.buildType}/test_constructor`);
|
|
const test_object = new TestConstructor();
|
|
|
|
assert.strictEqual(test_object.echo('hello'), 'hello');
|
|
|
|
test_object.readwriteValue = 1;
|
|
assert.strictEqual(test_object.readwriteValue, 1);
|
|
test_object.readwriteValue = 2;
|
|
assert.strictEqual(test_object.readwriteValue, 2);
|
|
|
|
assert.throws(() => { test_object.readonlyValue = 3; },
|
|
/^TypeError: Cannot assign to read only property 'readonlyValue' of object '#<MyObject>'$/);
|
|
|
|
assert.ok(test_object.hiddenValue);
|
|
|
|
// Properties with napi_enumerable attribute should be enumerable.
|
|
const propertyNames = [];
|
|
for (const name in test_object) {
|
|
propertyNames.push(name);
|
|
}
|
|
assert.ok(propertyNames.includes('echo'));
|
|
assert.ok(propertyNames.includes('readwriteValue'));
|
|
assert.ok(propertyNames.includes('readonlyValue'));
|
|
assert.ok(!propertyNames.includes('hiddenValue'));
|
|
assert.ok(!propertyNames.includes('readwriteAccessor1'));
|
|
assert.ok(!propertyNames.includes('readwriteAccessor2'));
|
|
assert.ok(!propertyNames.includes('readonlyAccessor1'));
|
|
assert.ok(!propertyNames.includes('readonlyAccessor2'));
|
|
|
|
// The napi_writable attribute should be ignored for accessors.
|
|
test_object.readwriteAccessor1 = 1;
|
|
assert.strictEqual(test_object.readwriteAccessor1, 1);
|
|
assert.strictEqual(test_object.readonlyAccessor1, 1);
|
|
assert.throws(() => { test_object.readonlyAccessor1 = 3; }, getterOnlyErrorRE);
|
|
test_object.readwriteAccessor2 = 2;
|
|
assert.strictEqual(test_object.readwriteAccessor2, 2);
|
|
assert.strictEqual(test_object.readonlyAccessor2, 2);
|
|
assert.throws(() => { test_object.readonlyAccessor2 = 3; }, getterOnlyErrorRE);
|
|
|
|
// Validate that static properties are on the class as opposed
|
|
// to the instance
|
|
assert.strictEqual(TestConstructor.staticReadonlyAccessor1, 10);
|
|
assert.strictEqual(test_object.staticReadonlyAccessor1, undefined);
|
|
|
|
// Verify that passing NULL to napi_define_class() results in the correct
|
|
// error.
|
|
assert.deepStrictEqual(TestConstructor.TestDefineClass(), {
|
|
envIsNull: 'Invalid argument',
|
|
nameIsNull: 'Invalid argument',
|
|
cbIsNull: 'Invalid argument',
|
|
cbDataIsNull: 'napi_ok',
|
|
propertiesIsNull: 'Invalid argument',
|
|
resultIsNull: 'Invalid argument'
|
|
});
|