mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 11:13:55 +00:00
b11e19e8ee
Currently http2 does not properly submit GOAWAY frames when a session is being destroyed. It also doesn't properly handle when the other party severs the connection after sending a GOAWAY frame, even though it should. Edge, IE & Safari are currently unable to handle empty TRAILERS frames despite them being correctly to spec. Instead send an empty DATA frame with END_STREAM flag in those situations. Fix and adjust several flaky and/or incorrect tests. PR-URL: https://github.com/nodejs/node/pull/20772 Fixes: https://github.com/nodejs/node/issues/20705 Fixes: https://github.com/nodejs/node/issues/20750 Fixes: https://github.com/nodejs/node/issues/20850 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
74 lines
1.9 KiB
JavaScript
74 lines
1.9 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
const body =
|
|
'<html><head></head><body><h1>this is some data</h2></body></html>';
|
|
const trailerKey = 'test-trailer';
|
|
const trailerValue = 'testing';
|
|
|
|
const server = h2.createServer();
|
|
|
|
// we use the lower-level API here
|
|
server.on('stream', common.mustCall(onStream));
|
|
|
|
function onStream(stream, headers, flags) {
|
|
stream.on('trailers', common.mustCall((headers) => {
|
|
assert.strictEqual(headers[trailerKey], trailerValue);
|
|
stream.end(body);
|
|
}));
|
|
stream.respond({
|
|
'content-type': 'text/html',
|
|
':status': 200
|
|
}, { waitForTrailers: true });
|
|
stream.on('wantTrailers', () => {
|
|
stream.sendTrailers({ [trailerKey]: trailerValue });
|
|
common.expectsError(
|
|
() => stream.sendTrailers({}),
|
|
{
|
|
code: 'ERR_HTTP2_TRAILERS_ALREADY_SENT',
|
|
type: Error
|
|
}
|
|
);
|
|
});
|
|
|
|
common.expectsError(
|
|
() => stream.sendTrailers({}),
|
|
{
|
|
code: 'ERR_HTTP2_TRAILERS_NOT_READY',
|
|
type: Error
|
|
}
|
|
);
|
|
}
|
|
|
|
server.listen(0);
|
|
|
|
server.on('listening', common.mustCall(function() {
|
|
const client = h2.connect(`http://localhost:${this.address().port}`);
|
|
const req = client.request({ ':path': '/', ':method': 'POST' },
|
|
{ waitForTrailers: true });
|
|
req.on('wantTrailers', () => {
|
|
req.sendTrailers({ [trailerKey]: trailerValue });
|
|
});
|
|
req.on('data', common.mustCall());
|
|
req.on('trailers', common.mustCall((headers) => {
|
|
assert.strictEqual(headers[trailerKey], trailerValue);
|
|
}));
|
|
req.on('close', common.mustCall(() => {
|
|
common.expectsError(
|
|
() => req.sendTrailers({}),
|
|
{
|
|
code: 'ERR_HTTP2_INVALID_STREAM',
|
|
type: Error
|
|
}
|
|
);
|
|
server.close();
|
|
client.close();
|
|
}));
|
|
req.end('data');
|
|
|
|
}));
|