node/test/parallel/test-http-client-override-global-agent.js
Robert Nagy b04e88439a http: don't destroy completed request
Calling destroy() on a completed ClientRequest, i.e.
once 'close' will be emitted should be a noop. Also
before emitting 'close' destroyed === true.

Fixes: https://github.com/nodejs/node/issues/32851

PR-URL: https://github.com/nodejs/node/pull/33120
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2020-05-11 18:02:32 +02:00

29 lines
684 B
JavaScript

'use strict';
const common = require('../common');
const assert = require('assert');
const http = require('http');
const server = http.Server(common.mustCall((req, res) => {
res.writeHead(200);
res.end('Hello, World!');
}));
server.listen(0, common.mustCall(() => {
const agent = new http.Agent();
const name = agent.getName({ port: server.address().port });
http.globalAgent = agent;
makeRequest();
assert(agent.sockets.hasOwnProperty(name)); // Agent has indeed been used
}));
function makeRequest() {
const req = http.get({
port: server.address().port
});
req.on('close', () => {
assert.strictEqual(req.destroyed, true);
server.close();
});
}