mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 05:41:13 +00:00
ac7d3fa0d9
RAND_screen() causes stability issues in invoking openssl-cli s_client on win2008r2 in CI. Disable to use it by adding -no_rand_screen options to all tls tests that use common.opensslCli. Fixes: https://github.com/nodejs/io.js/issues/2150 PR-URL: https://github.com/nodejs/io.js/pull/2209 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
47 lines
1.2 KiB
JavaScript
47 lines
1.2 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
if (!common.hasCrypto) {
|
|
console.log('1..0 # Skipped: missing crypto');
|
|
return;
|
|
}
|
|
var tls = require('tls');
|
|
|
|
var exec = require('child_process').exec;
|
|
var fs = require('fs');
|
|
|
|
var options = {
|
|
key: fs.readFileSync(common.fixturesDir + '/keys/agent2-key.pem'),
|
|
cert: fs.readFileSync(common.fixturesDir + '/keys/agent2-cert.pem'),
|
|
ciphers: 'ECDHE-RSA-RC4-SHA',
|
|
ecdhCurve: false
|
|
};
|
|
|
|
var nconns = 0;
|
|
|
|
process.on('exit', function() {
|
|
assert.equal(nconns, 0);
|
|
});
|
|
|
|
var server = tls.createServer(options, function(conn) {
|
|
conn.end();
|
|
nconns++;
|
|
});
|
|
|
|
server.listen(common.PORT, '127.0.0.1', function() {
|
|
var cmd = '"' + common.opensslCli + '" s_client -cipher ' + options.ciphers +
|
|
' -connect 127.0.0.1:' + common.PORT;
|
|
|
|
// for the performance and stability issue in s_client on Windows
|
|
if (process.platform === 'win32')
|
|
cmd += ' -no_rand_screen';
|
|
|
|
exec(cmd, function(err, stdout, stderr) {
|
|
// Old versions of openssl will still exit with 0 so we
|
|
// can't just check if err is not null.
|
|
assert.notEqual(stderr.indexOf('handshake failure'), -1);
|
|
server.close();
|
|
});
|
|
});
|