mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 23:52:54 +00:00
ac2fc0dd5f
ERR_INVALID_ARG_TYPE is the most common error used throughout the code base. This improves the error message by providing more details to the user and by indicating more precisely which values are allowed ones and which ones are not. It adds the actual input to the error message in case it's a primitive. If it's a class instance, it'll print the class name instead of "object" and "falsy" or similar entries are not named "type" anymore. PR-URL: https://github.com/nodejs/node/pull/29675 Reviewed-By: Rich Trott <rtrott@gmail.com>
98 lines
2.3 KiB
JavaScript
98 lines
2.3 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const vm = require('vm');
|
|
const spawnSync = require('child_process').spawnSync;
|
|
|
|
function getSource(tag) {
|
|
return `(function ${tag}() { return '${tag}'; })`;
|
|
}
|
|
|
|
function produce(source, count) {
|
|
if (!count)
|
|
count = 1;
|
|
|
|
const out = spawnSync(process.execPath, [ '-e', `
|
|
'use strict';
|
|
const assert = require('assert');
|
|
const vm = require('vm');
|
|
|
|
var data;
|
|
for (var i = 0; i < ${count}; i++) {
|
|
var script = new vm.Script(process.argv[1], {
|
|
produceCachedData: true
|
|
});
|
|
|
|
assert(!script.cachedDataProduced || script.cachedData instanceof Buffer);
|
|
|
|
if (script.cachedDataProduced)
|
|
data = script.cachedData.toString('base64');
|
|
}
|
|
console.log(data);
|
|
`, source]);
|
|
|
|
assert.strictEqual(out.status, 0, String(out.stderr));
|
|
|
|
return Buffer.from(out.stdout.toString(), 'base64');
|
|
}
|
|
|
|
function testProduceConsume() {
|
|
const source = getSource('original');
|
|
|
|
const data = produce(source);
|
|
|
|
for (const cachedData of common.getArrayBufferViews(data)) {
|
|
// It should consume code cache
|
|
const script = new vm.Script(source, {
|
|
cachedData
|
|
});
|
|
assert(!script.cachedDataRejected);
|
|
assert.strictEqual(script.runInThisContext()(), 'original');
|
|
}
|
|
}
|
|
testProduceConsume();
|
|
|
|
function testProduceMultiple() {
|
|
const source = getSource('original');
|
|
|
|
produce(source, 3);
|
|
}
|
|
testProduceMultiple();
|
|
|
|
function testRejectInvalid() {
|
|
const source = getSource('invalid');
|
|
|
|
const data = produce(source);
|
|
|
|
// It should reject invalid code cache
|
|
const script = new vm.Script(getSource('invalid_1'), {
|
|
cachedData: data
|
|
});
|
|
assert(script.cachedDataRejected);
|
|
assert.strictEqual(script.runInThisContext()(), 'invalid_1');
|
|
}
|
|
testRejectInvalid();
|
|
|
|
function testRejectSlice() {
|
|
const source = getSource('slice');
|
|
|
|
const data = produce(source).slice(4);
|
|
|
|
const script = new vm.Script(source, {
|
|
cachedData: data
|
|
});
|
|
assert(script.cachedDataRejected);
|
|
}
|
|
testRejectSlice();
|
|
|
|
// It should throw on non-Buffer cachedData
|
|
common.expectsError(() => {
|
|
new vm.Script('function abc() {}', {
|
|
cachedData: 'ohai'
|
|
});
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: /must be an instance of Buffer, TypedArray, or DataView/
|
|
});
|