mirror of
https://github.com/nodejs/node.git
synced 2025-05-14 20:02:04 +00:00
ac2fc0dd5f
ERR_INVALID_ARG_TYPE is the most common error used throughout the code base. This improves the error message by providing more details to the user and by indicating more precisely which values are allowed ones and which ones are not. It adds the actual input to the error message in case it's a primitive. If it's a class instance, it'll print the class name instead of "object" and "falsy" or similar entries are not named "type" anymore. PR-URL: https://github.com/nodejs/node/pull/29675 Reviewed-By: Rich Trott <rtrott@gmail.com>
122 lines
3.4 KiB
JavaScript
122 lines
3.4 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const http = require('http');
|
|
const OutgoingMessage = http.OutgoingMessage;
|
|
const ClientRequest = http.ClientRequest;
|
|
const ServerResponse = http.ServerResponse;
|
|
|
|
assert.strictEqual(
|
|
typeof ClientRequest.prototype._implicitHeader, 'function');
|
|
assert.strictEqual(
|
|
typeof ServerResponse.prototype._implicitHeader, 'function');
|
|
|
|
// validateHeader
|
|
common.expectsError(() => {
|
|
const outgoingMessage = new OutgoingMessage();
|
|
outgoingMessage.setHeader();
|
|
}, {
|
|
code: 'ERR_INVALID_HTTP_TOKEN',
|
|
type: TypeError,
|
|
message: 'Header name must be a valid HTTP token ["undefined"]'
|
|
});
|
|
|
|
common.expectsError(() => {
|
|
const outgoingMessage = new OutgoingMessage();
|
|
outgoingMessage.setHeader('test');
|
|
}, {
|
|
code: 'ERR_HTTP_INVALID_HEADER_VALUE',
|
|
type: TypeError,
|
|
message: 'Invalid value "undefined" for header "test"'
|
|
});
|
|
|
|
common.expectsError(() => {
|
|
const outgoingMessage = new OutgoingMessage();
|
|
outgoingMessage.setHeader(404);
|
|
}, {
|
|
code: 'ERR_INVALID_HTTP_TOKEN',
|
|
type: TypeError,
|
|
message: 'Header name must be a valid HTTP token ["404"]'
|
|
});
|
|
|
|
common.expectsError(() => {
|
|
const outgoingMessage = new OutgoingMessage();
|
|
outgoingMessage.setHeader.call({ _header: 'test' }, 'test', 'value');
|
|
}, {
|
|
code: 'ERR_HTTP_HEADERS_SENT',
|
|
type: Error,
|
|
message: 'Cannot set headers after they are sent to the client'
|
|
});
|
|
|
|
common.expectsError(() => {
|
|
const outgoingMessage = new OutgoingMessage();
|
|
outgoingMessage.setHeader('200', 'あ');
|
|
}, {
|
|
code: 'ERR_INVALID_CHAR',
|
|
type: TypeError,
|
|
message: 'Invalid character in header content ["200"]'
|
|
});
|
|
|
|
// write
|
|
{
|
|
const outgoingMessage = new OutgoingMessage();
|
|
|
|
outgoingMessage.on('error', common.expectsError({
|
|
code: 'ERR_METHOD_NOT_IMPLEMENTED',
|
|
type: Error,
|
|
message: 'The _implicitHeader() method is not implemented'
|
|
}));
|
|
|
|
outgoingMessage.write('');
|
|
}
|
|
|
|
assert(OutgoingMessage.prototype.write.call({ _header: 'test' }));
|
|
|
|
common.expectsError(() => {
|
|
const outgoingMessage = new OutgoingMessage();
|
|
outgoingMessage.write.call({ _header: 'test', _hasBody: 'test' });
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The first argument must be of type string or an instance of ' +
|
|
'Buffer. Received undefined'
|
|
});
|
|
|
|
common.expectsError(() => {
|
|
const outgoingMessage = new OutgoingMessage();
|
|
outgoingMessage.write.call({ _header: 'test', _hasBody: 'test' }, 1);
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The first argument must be of type string or an instance of ' +
|
|
'Buffer. Received type number (1)'
|
|
});
|
|
|
|
// addTrailers()
|
|
// The `Error` comes from the JavaScript engine so confirm that it is a
|
|
// `TypeError` but do not check the message. It will be different in different
|
|
// JavaScript engines.
|
|
assert.throws(() => {
|
|
const outgoingMessage = new OutgoingMessage();
|
|
outgoingMessage.addTrailers();
|
|
}, TypeError);
|
|
|
|
common.expectsError(() => {
|
|
const outgoingMessage = new OutgoingMessage();
|
|
outgoingMessage.addTrailers({ 'あ': 'value' });
|
|
}, {
|
|
code: 'ERR_INVALID_HTTP_TOKEN',
|
|
type: TypeError,
|
|
message: 'Trailer name must be a valid HTTP token ["あ"]'
|
|
});
|
|
|
|
common.expectsError(() => {
|
|
const outgoingMessage = new OutgoingMessage();
|
|
outgoingMessage.addTrailers({ 404: 'あ' });
|
|
}, {
|
|
code: 'ERR_INVALID_CHAR',
|
|
type: TypeError,
|
|
message: 'Invalid character in trailer content ["404"]'
|
|
});
|