mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 23:06:47 +00:00
ac2fc0dd5f
ERR_INVALID_ARG_TYPE is the most common error used throughout the code base. This improves the error message by providing more details to the user and by indicating more precisely which values are allowed ones and which ones are not. It adds the actual input to the error message in case it's a primitive. If it's a class instance, it'll print the class name instead of "object" and "falsy" or similar entries are not named "type" anymore. PR-URL: https://github.com/nodejs/node/pull/29675 Reviewed-By: Rich Trott <rtrott@gmail.com>
42 lines
1.2 KiB
JavaScript
42 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const http = require('http');
|
|
|
|
// All of these values should cause http.request() to throw synchronously
|
|
// when passed as the value of either options.hostname or options.host
|
|
const vals = [{}, [], NaN, Infinity, -Infinity, true, false, 1, 0, new Date()];
|
|
|
|
vals.forEach((v) => {
|
|
const received = common.invalidArgTypeHelper(v);
|
|
common.expectsError(
|
|
() => http.request({ hostname: v }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "options.hostname" property must be of ' +
|
|
'type string or one of undefined or null.' +
|
|
received
|
|
}
|
|
);
|
|
|
|
common.expectsError(
|
|
() => http.request({ host: v }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "options.host" property must be of ' +
|
|
'type string or one of undefined or null.' +
|
|
received
|
|
}
|
|
);
|
|
});
|
|
|
|
// These values are OK and should not throw synchronously.
|
|
// Only testing for 'hostname' validation so ignore connection errors.
|
|
const dontCare = () => {};
|
|
['', undefined, null].forEach((v) => {
|
|
http.request({ hostname: v }).on('error', dontCare).end();
|
|
http.request({ host: v }).on('error', dontCare).end();
|
|
});
|