mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 09:02:40 +00:00

ERR_INVALID_ARG_TYPE is the most common error used throughout the code base. This improves the error message by providing more details to the user and by indicating more precisely which values are allowed ones and which ones are not. It adds the actual input to the error message in case it's a primitive. If it's a class instance, it'll print the class name instead of "object" and "falsy" or similar entries are not named "type" anymore. PR-URL: https://github.com/nodejs/node/pull/29675 Reviewed-By: Rich Trott <rtrott@gmail.com>
70 lines
1.4 KiB
JavaScript
70 lines
1.4 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
|
|
const baseOptions = {
|
|
method: 'GET',
|
|
port: undefined,
|
|
host: common.localhostIPv4,
|
|
};
|
|
|
|
const failingAgentOptions = [
|
|
true,
|
|
'agent',
|
|
{},
|
|
1,
|
|
() => null,
|
|
Symbol(),
|
|
];
|
|
|
|
const acceptableAgentOptions = [
|
|
false,
|
|
undefined,
|
|
null,
|
|
new http.Agent(),
|
|
];
|
|
|
|
const server = http.createServer((req, res) => {
|
|
res.end('hello');
|
|
});
|
|
|
|
let numberOfResponses = 0;
|
|
|
|
function createRequest(agent) {
|
|
const options = Object.assign(baseOptions, { agent });
|
|
const request = http.request(options);
|
|
request.end();
|
|
request.on('response', common.mustCall(() => {
|
|
numberOfResponses++;
|
|
if (numberOfResponses === acceptableAgentOptions.length) {
|
|
server.close();
|
|
}
|
|
}));
|
|
}
|
|
|
|
server.listen(0, baseOptions.host, common.mustCall(function() {
|
|
baseOptions.port = this.address().port;
|
|
|
|
failingAgentOptions.forEach((agent) => {
|
|
common.expectsError(
|
|
() => createRequest(agent),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "options.agent" property must be one of Agent-like ' +
|
|
'Object, undefined, or false.' +
|
|
common.invalidArgTypeHelper(agent)
|
|
}
|
|
);
|
|
});
|
|
|
|
acceptableAgentOptions.forEach((agent) => {
|
|
createRequest(agent);
|
|
});
|
|
}));
|
|
|
|
process.on('exit', () => {
|
|
assert.strictEqual(numberOfResponses, acceptableAgentOptions.length);
|
|
});
|