mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 23:56:58 +00:00
ac2fc0dd5f
ERR_INVALID_ARG_TYPE is the most common error used throughout the code base. This improves the error message by providing more details to the user and by indicating more precisely which values are allowed ones and which ones are not. It adds the actual input to the error message in case it's a primitive. If it's a class instance, it'll print the class name instead of "object" and "falsy" or similar entries are not named "type" anymore. PR-URL: https://github.com/nodejs/node/pull/29675 Reviewed-By: Rich Trott <rtrott@gmail.com>
141 lines
3.4 KiB
JavaScript
141 lines
3.4 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const fs = require('fs');
|
|
const assert = require('assert');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const filepath = fixtures.path('x.txt');
|
|
const fd = fs.openSync(filepath, 'r');
|
|
const expected = 'xyz\n';
|
|
|
|
|
|
// Error must be thrown with string
|
|
assert.throws(
|
|
() => fs.read(fd, expected.length, 0, 'utf-8', common.mustNotCall()),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "buffer" argument must be an instance of Buffer, ' +
|
|
'TypedArray, or DataView. Received type number (4)'
|
|
}
|
|
);
|
|
|
|
[true, null, undefined, () => {}, {}].forEach((value) => {
|
|
assert.throws(() => {
|
|
fs.read(value,
|
|
Buffer.allocUnsafe(expected.length),
|
|
0,
|
|
expected.length,
|
|
0,
|
|
common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
});
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.read(fd,
|
|
Buffer.allocUnsafe(expected.length),
|
|
-1,
|
|
expected.length,
|
|
0,
|
|
common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "offset" is out of range. It must be >= 0 && <= 4. ' +
|
|
'Received -1'
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.read(fd,
|
|
Buffer.allocUnsafe(expected.length),
|
|
NaN,
|
|
expected.length,
|
|
0,
|
|
common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "offset" is out of range. It must be an integer. ' +
|
|
'Received NaN'
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.read(fd,
|
|
Buffer.allocUnsafe(expected.length),
|
|
0,
|
|
-1,
|
|
0,
|
|
common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "length" is out of range. ' +
|
|
'It must be >= 0 && <= 4. Received -1'
|
|
});
|
|
|
|
|
|
assert.throws(
|
|
() => fs.readSync(fd, expected.length, 0, 'utf-8'),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "buffer" argument must be an instance of Buffer, ' +
|
|
'TypedArray, or DataView. Received type number (4)'
|
|
}
|
|
);
|
|
|
|
[true, null, undefined, () => {}, {}].forEach((value) => {
|
|
assert.throws(() => {
|
|
fs.readSync(value,
|
|
Buffer.allocUnsafe(expected.length),
|
|
0,
|
|
expected.length,
|
|
0);
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
});
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.readSync(fd,
|
|
Buffer.allocUnsafe(expected.length),
|
|
-1,
|
|
expected.length,
|
|
0);
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "offset" is out of range. ' +
|
|
'It must be >= 0 && <= 4. Received -1'
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.readSync(fd,
|
|
Buffer.allocUnsafe(expected.length),
|
|
NaN,
|
|
expected.length,
|
|
0);
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "offset" is out of range. It must be an integer. ' +
|
|
'Received NaN'
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.readSync(fd,
|
|
Buffer.allocUnsafe(expected.length),
|
|
0,
|
|
-1,
|
|
0);
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "length" is out of range. ' +
|
|
'It must be >= 0 && <= 4. Received -1'
|
|
});
|