mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 03:13:13 +00:00
ac2fc0dd5f
ERR_INVALID_ARG_TYPE is the most common error used throughout the code base. This improves the error message by providing more details to the user and by indicating more precisely which values are allowed ones and which ones are not. It adds the actual input to the error message in case it's a primitive. If it's a class instance, it'll print the class name instead of "object" and "falsy" or similar entries are not named "type" anymore. PR-URL: https://github.com/nodejs/node/pull/29675 Reviewed-By: Rich Trott <rtrott@gmail.com>
65 lines
1.4 KiB
JavaScript
65 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const { deepStrictEqual, throws } = require('assert');
|
|
const { runInNewContext } = require('vm');
|
|
|
|
const checkString = 'test';
|
|
|
|
const check = Buffer.from(checkString);
|
|
|
|
class MyString extends String {
|
|
constructor() {
|
|
super(checkString);
|
|
}
|
|
}
|
|
|
|
class MyPrimitive {
|
|
[Symbol.toPrimitive]() {
|
|
return checkString;
|
|
}
|
|
}
|
|
|
|
class MyBadPrimitive {
|
|
[Symbol.toPrimitive]() {
|
|
return 1;
|
|
}
|
|
}
|
|
|
|
deepStrictEqual(Buffer.from(new String(checkString)), check);
|
|
deepStrictEqual(Buffer.from(new MyString()), check);
|
|
deepStrictEqual(Buffer.from(new MyPrimitive()), check);
|
|
deepStrictEqual(
|
|
Buffer.from(runInNewContext('new String(checkString)', { checkString })),
|
|
check
|
|
);
|
|
|
|
[
|
|
{},
|
|
new Boolean(true),
|
|
{ valueOf() { return null; } },
|
|
{ valueOf() { return undefined; } },
|
|
{ valueOf: null },
|
|
Object.create(null),
|
|
new Number(true),
|
|
new MyBadPrimitive(),
|
|
Symbol(),
|
|
5n,
|
|
(one, two, three) => {},
|
|
undefined,
|
|
null
|
|
].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The first argument must be of type string or an instance of ' +
|
|
'Buffer, ArrayBuffer, or Array or an Array-like Object.' +
|
|
common.invalidArgTypeHelper(input)
|
|
};
|
|
throws(() => Buffer.from(input), errObj);
|
|
throws(() => Buffer.from(input, 'hex'), errObj);
|
|
});
|
|
|
|
Buffer.allocUnsafe(10); // Should not throw.
|
|
Buffer.from('deadbeaf', 'hex'); // Should not throw.
|