mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 12:49:07 +00:00
a74a6e3ba1
Throwing an exception from a finalizer can cause the following fatal
error:
Error: async hook stack has become corrupted (actual: 2, expected: 0)
1: 0x970b5a node::InternalCallbackScope::~InternalCallbackScope()
[./node]
2: 0x99dda0 node::Environment::RunTimers(uv_timer_s*) [./node]
3: 0x13d8b22 [./node]
4: 0x13dbe42 uv_run [./node]
5: 0xa57974 node::NodeMainInstance::Run() [./node]
6: 0x9dbc17 node::Start(int, char**) [./node]
7: 0x7f4965417f43 __libc_start_main [/lib64/libc.so.6]
8: 0x96f4ae _start [./node]
By https://github.com/nodejs/node/issues/34341#issuecomment-658426281,
calling into JS from a finalizer and/or throwing exceptions from there
is not advised, because the stack may or may not be set up for JS
execution. The best solution is to run the user's finalizer from a
`SetImmediate()` callback.
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Fixes: https://github.com/nodejs/node/issues/34341
PR-URL: https://github.com/nodejs/node/pull/34386
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
97 lines
3.0 KiB
JavaScript
97 lines
3.0 KiB
JavaScript
'use strict';
|
|
// Flags: --expose-gc
|
|
|
|
const common = require('../../common');
|
|
const test_general = require(`./build/${common.buildType}/test_general`);
|
|
const assert = require('assert');
|
|
|
|
const val1 = '1';
|
|
const val2 = 1;
|
|
const val3 = 1;
|
|
|
|
class BaseClass {
|
|
}
|
|
|
|
class ExtendedClass extends BaseClass {
|
|
}
|
|
|
|
const baseObject = new BaseClass();
|
|
const extendedObject = new ExtendedClass();
|
|
|
|
// Test napi_strict_equals
|
|
assert.ok(test_general.testStrictEquals(val1, val1));
|
|
assert.strictEqual(test_general.testStrictEquals(val1, val2), false);
|
|
assert.ok(test_general.testStrictEquals(val2, val3));
|
|
|
|
// Test napi_get_prototype
|
|
assert.strictEqual(test_general.testGetPrototype(baseObject),
|
|
Object.getPrototypeOf(baseObject));
|
|
assert.strictEqual(test_general.testGetPrototype(extendedObject),
|
|
Object.getPrototypeOf(extendedObject));
|
|
// Prototypes for base and extended should be different.
|
|
assert.notStrictEqual(test_general.testGetPrototype(baseObject),
|
|
test_general.testGetPrototype(extendedObject));
|
|
|
|
// Test version management functions
|
|
assert.strictEqual(test_general.testGetVersion(), 6);
|
|
|
|
[
|
|
123,
|
|
'test string',
|
|
function() {},
|
|
new Object(),
|
|
true,
|
|
undefined,
|
|
Symbol()
|
|
].forEach((val) => {
|
|
assert.strictEqual(test_general.testNapiTypeof(val), typeof val);
|
|
});
|
|
|
|
// Since typeof in js return object need to validate specific case
|
|
// for null
|
|
assert.strictEqual(test_general.testNapiTypeof(null), 'null');
|
|
|
|
// Assert that wrapping twice fails.
|
|
const x = {};
|
|
test_general.wrap(x);
|
|
assert.throws(() => test_general.wrap(x),
|
|
{ name: 'Error', message: 'Invalid argument' });
|
|
// Clean up here, otherwise derefItemWasCalled() will be polluted.
|
|
test_general.removeWrap(x);
|
|
|
|
// Ensure that wrapping, removing the wrap, and then wrapping again works.
|
|
const y = {};
|
|
test_general.wrap(y);
|
|
test_general.removeWrap(y);
|
|
// Wrapping twice succeeds if a remove_wrap() separates the instances
|
|
test_general.wrap(y);
|
|
// Clean up here, otherwise derefItemWasCalled() will be polluted.
|
|
test_general.removeWrap(y);
|
|
|
|
// Test napi_adjust_external_memory
|
|
const adjustedValue = test_general.testAdjustExternalMemory();
|
|
assert.strictEqual(typeof adjustedValue, 'number');
|
|
assert(adjustedValue > 0);
|
|
|
|
async function runGCTests() {
|
|
// Ensure that garbage collecting an object with a wrapped native item results
|
|
// in the finalize callback being called.
|
|
assert.strictEqual(test_general.derefItemWasCalled(), false);
|
|
|
|
(() => test_general.wrap({}))();
|
|
await common.gcUntil('deref_item() was called upon garbage collecting a ' +
|
|
'wrapped object.',
|
|
() => test_general.derefItemWasCalled());
|
|
|
|
// Ensure that removing a wrap and garbage collecting does not fire the
|
|
// finalize callback.
|
|
let z = {};
|
|
test_general.testFinalizeWrap(z);
|
|
test_general.removeWrap(z);
|
|
z = null;
|
|
await common.gcUntil(
|
|
'finalize callback was not called upon garbage collection.',
|
|
() => (!test_general.finalizeWasCalled()));
|
|
}
|
|
runGCTests();
|