mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 13:11:36 +00:00
a74a6e3ba1
Throwing an exception from a finalizer can cause the following fatal
error:
Error: async hook stack has become corrupted (actual: 2, expected: 0)
1: 0x970b5a node::InternalCallbackScope::~InternalCallbackScope()
[./node]
2: 0x99dda0 node::Environment::RunTimers(uv_timer_s*) [./node]
3: 0x13d8b22 [./node]
4: 0x13dbe42 uv_run [./node]
5: 0xa57974 node::NodeMainInstance::Run() [./node]
6: 0x9dbc17 node::Start(int, char**) [./node]
7: 0x7f4965417f43 __libc_start_main [/lib64/libc.so.6]
8: 0x96f4ae _start [./node]
By https://github.com/nodejs/node/issues/34341#issuecomment-658426281,
calling into JS from a finalizer and/or throwing exceptions from there
is not advised, because the stack may or may not be set up for JS
execution. The best solution is to run the user's finalizer from a
`SetImmediate()` callback.
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Fixes: https://github.com/nodejs/node/issues/34341
PR-URL: https://github.com/nodejs/node/pull/34386
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
69 lines
2.5 KiB
JavaScript
69 lines
2.5 KiB
JavaScript
'use strict';
|
|
// Flags: --expose-gc
|
|
|
|
const common = require('../../common');
|
|
const assert = require('assert');
|
|
const theError = new Error('Some error');
|
|
|
|
// The test module throws an error during Init, but in order for its exports to
|
|
// not be lost, it attaches them to the error's "bindings" property. This way,
|
|
// we can make sure that exceptions thrown during the module initialization
|
|
// phase are propagated through require() into JavaScript.
|
|
// https://github.com/nodejs/node/issues/19437
|
|
const test_exception = (function() {
|
|
let resultingException;
|
|
try {
|
|
require(`./build/${common.buildType}/test_exception`);
|
|
} catch (anException) {
|
|
resultingException = anException;
|
|
}
|
|
assert.strictEqual(resultingException.message, 'Error during Init');
|
|
return resultingException.binding;
|
|
})();
|
|
|
|
{
|
|
const throwTheError = () => { throw theError; };
|
|
|
|
// Test that the native side successfully captures the exception
|
|
let returnedError = test_exception.returnException(throwTheError);
|
|
assert.strictEqual(returnedError, theError);
|
|
|
|
// Test that the native side passes the exception through
|
|
assert.throws(
|
|
() => { test_exception.allowException(throwTheError); },
|
|
(err) => err === theError
|
|
);
|
|
|
|
// Test that the exception thrown above was marked as pending
|
|
// before it was handled on the JS side
|
|
const exception_pending = test_exception.wasPending();
|
|
assert.strictEqual(exception_pending, true,
|
|
'Exception not pending as expected,' +
|
|
` .wasPending() returned ${exception_pending}`);
|
|
|
|
// Test that the native side does not capture a non-existing exception
|
|
returnedError = test_exception.returnException(common.mustCall());
|
|
assert.strictEqual(returnedError, undefined,
|
|
'Returned error should be undefined when no exception is' +
|
|
` thrown, but ${returnedError} was passed`);
|
|
}
|
|
|
|
{
|
|
// Test that no exception appears that was not thrown by us
|
|
let caughtError;
|
|
try {
|
|
test_exception.allowException(common.mustCall());
|
|
} catch (anError) {
|
|
caughtError = anError;
|
|
}
|
|
assert.strictEqual(caughtError, undefined,
|
|
'No exception originated on the native side, but' +
|
|
` ${caughtError} was passed`);
|
|
|
|
// Test that the exception state remains clear when no exception is thrown
|
|
const exception_pending = test_exception.wasPending();
|
|
assert.strictEqual(exception_pending, false,
|
|
'Exception state did not remain clear as expected,' +
|
|
` .wasPending() returned ${exception_pending}`);
|
|
}
|