mirror of
https://github.com/nodejs/node.git
synced 2025-05-12 02:02:29 +00:00

I noticed that we were taking `TimerCb` as a `const&` and then copying that into the member. This is completely fine when the constructor is called with an lvalue. However, when called with an rvalue, we can allow the `std::function` to be moved into the member instead of falling back to a copy, so I changed the constructors to take in universal references. Also, `std::function` constructors can take in multiple arguments, so I further modified the constructors to use variadic templates. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/40665 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
84 lines
1.8 KiB
C++
84 lines
1.8 KiB
C++
#include "timer_wrap.h" // NOLINT(build/include_inline)
|
|
#include "timer_wrap-inl.h"
|
|
|
|
#include "env-inl.h"
|
|
#include "memory_tracker-inl.h"
|
|
#include "uv.h"
|
|
|
|
namespace node {
|
|
|
|
void TimerWrap::Stop() {
|
|
if (timer_.data == nullptr) return;
|
|
uv_timer_stop(&timer_);
|
|
}
|
|
|
|
void TimerWrap::Close() {
|
|
timer_.data = nullptr;
|
|
env_->CloseHandle(reinterpret_cast<uv_handle_t*>(&timer_), TimerClosedCb);
|
|
}
|
|
|
|
void TimerWrap::TimerClosedCb(uv_handle_t* handle) {
|
|
std::unique_ptr<TimerWrap> ptr(
|
|
ContainerOf(&TimerWrap::timer_,
|
|
reinterpret_cast<uv_timer_t*>(handle)));
|
|
}
|
|
|
|
void TimerWrap::Update(uint64_t interval, uint64_t repeat) {
|
|
if (timer_.data == nullptr) return;
|
|
uv_timer_start(&timer_, OnTimeout, interval, repeat);
|
|
}
|
|
|
|
void TimerWrap::Ref() {
|
|
if (timer_.data == nullptr) return;
|
|
uv_ref(reinterpret_cast<uv_handle_t*>(&timer_));
|
|
}
|
|
|
|
void TimerWrap::Unref() {
|
|
if (timer_.data == nullptr) return;
|
|
uv_unref(reinterpret_cast<uv_handle_t*>(&timer_));
|
|
}
|
|
|
|
void TimerWrap::OnTimeout(uv_timer_t* timer) {
|
|
TimerWrap* t = ContainerOf(&TimerWrap::timer_, timer);
|
|
t->fn_();
|
|
}
|
|
|
|
void TimerWrapHandle::Stop() {
|
|
if (timer_ != nullptr)
|
|
return timer_->Stop();
|
|
}
|
|
|
|
void TimerWrapHandle::Close() {
|
|
if (timer_ != nullptr) {
|
|
timer_->env()->RemoveCleanupHook(CleanupHook, this);
|
|
timer_->Close();
|
|
}
|
|
timer_ = nullptr;
|
|
}
|
|
|
|
void TimerWrapHandle::Ref() {
|
|
if (timer_ != nullptr)
|
|
timer_->Ref();
|
|
}
|
|
|
|
void TimerWrapHandle::Unref() {
|
|
if (timer_ != nullptr)
|
|
timer_->Unref();
|
|
}
|
|
|
|
void TimerWrapHandle::Update(uint64_t interval, uint64_t repeat) {
|
|
if (timer_ != nullptr)
|
|
timer_->Update(interval, repeat);
|
|
}
|
|
|
|
void TimerWrapHandle::MemoryInfo(MemoryTracker* tracker) const {
|
|
if (timer_ != nullptr)
|
|
tracker->TrackField("timer", *timer_);
|
|
}
|
|
|
|
void TimerWrapHandle::CleanupHook(void* data) {
|
|
static_cast<TimerWrapHandle*>(data)->Close();
|
|
}
|
|
|
|
} // namespace node
|