mirror of
https://github.com/nodejs/node.git
synced 2025-05-15 08:02:06 +00:00

PR-URL: https://github.com/nodejs/node/pull/54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
126 lines
4.5 KiB
C++
126 lines
4.5 KiB
C++
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/common/globals.h"
|
|
#include "src/heap/heap-inl.h"
|
|
#include "src/heap/memory-chunk-metadata.h"
|
|
#include "src/objects/cell.h"
|
|
#include "src/objects/feedback-cell.h"
|
|
#include "src/objects/script.h"
|
|
#include "src/roots/roots-inl.h"
|
|
#include "test/unittests/test-utils.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
using RootsTest = TestWithIsolate;
|
|
|
|
namespace {
|
|
AllocationSpace GetSpaceFromObject(Tagged<Object> object) {
|
|
DCHECK(IsHeapObject(object));
|
|
MemoryChunk* chunk = MemoryChunk::FromHeapObject(Cast<HeapObject>(object));
|
|
if (chunk->InReadOnlySpace()) return RO_SPACE;
|
|
return chunk->Metadata()->owner()->identity();
|
|
}
|
|
} // namespace
|
|
|
|
#define CHECK_IN_RO_SPACE(type, name, CamelName) \
|
|
Tagged<HeapObject> name = roots.name(); \
|
|
CHECK_EQ(RO_SPACE, GetSpaceFromObject(name));
|
|
|
|
// The following tests check that all the roots accessible via ReadOnlyRoots are
|
|
// in RO_SPACE.
|
|
TEST_F(RootsTest, TestReadOnlyRoots) {
|
|
ReadOnlyRoots roots(i_isolate());
|
|
|
|
READ_ONLY_ROOT_LIST(CHECK_IN_RO_SPACE)
|
|
}
|
|
|
|
#undef CHECK_IN_RO_SPACE
|
|
|
|
namespace {
|
|
// Applies to objects in mutable root slots; specific slots may point into RO
|
|
// space (e.g. because the slot value may change and only the initial value is
|
|
// in RO space; or, because RO promotion dynamically decides whether to promote
|
|
// the slot value to RO space).
|
|
bool CanBeInReadOnlySpace(Factory* factory, Handle<Object> object) {
|
|
// Entries in this list are in STRONG_MUTABLE_MOVABLE_ROOT_LIST, but may
|
|
// initially point to objects that are in RO_SPACE.
|
|
#define INITIALLY_READ_ONLY_ROOT_LIST(V) \
|
|
V(api_private_symbol_table) \
|
|
V(api_symbol_table) \
|
|
V(basic_block_profiling_data) \
|
|
V(builtins_constants_table) \
|
|
V(current_microtask) \
|
|
V(detached_contexts) \
|
|
V(feedback_vectors_for_profiling_tools) \
|
|
V(shared_wasm_memories) \
|
|
V(materialized_objects) \
|
|
V(public_symbol_table) \
|
|
V(serialized_global_proxy_sizes) \
|
|
V(serialized_objects) \
|
|
IF_WASM(V, js_to_wasm_wrappers) \
|
|
IF_WASM(V, wasm_canonical_rtts) \
|
|
V(weak_refs_keep_during_job)
|
|
|
|
#define TEST_CAN_BE_READ_ONLY(name) \
|
|
if (factory->name().address() == object.address()) return true;
|
|
INITIALLY_READ_ONLY_ROOT_LIST(TEST_CAN_BE_READ_ONLY)
|
|
#undef TEST_CAN_BE_READ_ONLY
|
|
#undef INITIALLY_READ_ONLY_ROOT_LIST
|
|
|
|
// May be promoted to RO space, see read-only-promotion.h.
|
|
if (IsAccessorInfo(*object)) return true;
|
|
if (IsFunctionTemplateInfo(*object)) return true;
|
|
if (IsFunctionTemplateRareData(*object)) return true;
|
|
if (IsSharedFunctionInfo(*object)) return true;
|
|
|
|
return false;
|
|
}
|
|
|
|
// Some mutable roots may initially point to undefined until they are properly
|
|
// initialized.
|
|
bool IsUninitialized(DirectHandle<Object> object) {
|
|
return !IsTrustedObject(*object) && IsUndefined(*object);
|
|
}
|
|
} // namespace
|
|
|
|
// The CHECK_EQ line is there just to ensure that the root is publicly
|
|
// accessible from Heap, but ultimately the factory is used as it provides
|
|
// handles that have the address in the root table.
|
|
#define CHECK_NOT_IN_RO_SPACE(type, name, CamelName) \
|
|
Handle<Object> name = factory->name(); \
|
|
CHECK_EQ(*name, heap->name()); \
|
|
if (IsHeapObject(*name) && !CanBeInReadOnlySpace(factory, name) && \
|
|
!IsUninitialized(name)) { \
|
|
CHECK_NE(RO_SPACE, GetSpaceFromObject(Cast<HeapObject>(*name))); \
|
|
}
|
|
|
|
// The following tests check that all the roots accessible via public Heap
|
|
// accessors are not in RO_SPACE (with some exceptions, see
|
|
// CanBeInReadOnlySpace).
|
|
TEST_F(RootsTest, TestHeapRootsNotReadOnly) {
|
|
Factory* factory = i_isolate()->factory();
|
|
Heap* heap = i_isolate()->heap();
|
|
|
|
MUTABLE_ROOT_LIST(CHECK_NOT_IN_RO_SPACE)
|
|
}
|
|
|
|
TEST_F(RootsTest, TestHeapNumberList) {
|
|
ReadOnlyRoots roots(isolate());
|
|
for (auto pos = RootIndex::kFirstReadOnlyRoot;
|
|
pos <= RootIndex::kLastReadOnlyRoot; ++pos) {
|
|
auto obj = roots.object_at(pos);
|
|
bool in_nr_range = pos >= RootIndex::kFirstHeapNumberRoot &&
|
|
pos <= RootIndex::kLastHeapNumberRoot;
|
|
CHECK_EQ(IsHeapNumber(obj), in_nr_range);
|
|
}
|
|
}
|
|
|
|
#undef CHECK_NOT_IN_RO_SPACE
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|