mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 07:51:12 +00:00
dd52c05046
Comparing any value to any non-RegExp literal or undefined using
strictEqual (or notStrictEqual) passes if and only if deepStrictEqual
(or notDeepStrictEqual, respectively) passes.
Unnecessarily using deep comparisons adds confusion.
This patch adds an ESLint rule that forbids the use of deepStrictEqual
and notDeepStrictEqual when the expected value (i.e., the second
argument) is a non-RegExp literal or undefined.
For reference, an ESTree literal is defined as follows.
extend interface Literal <: Expression {
type: "Literal";
value: string | boolean | null | number | RegExp | bigint;
}
The value `undefined` is an `Identifier` with `name: 'undefined'`.
PR-URL: https://github.com/nodejs/node/pull/40634
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
38 lines
892 B
JavaScript
38 lines
892 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const zlib = require('zlib');
|
|
|
|
// Tests that zlib streams support .reset() and .params()
|
|
// before the first write. That is important to ensure that
|
|
// lazy init of zlib native library handles these cases.
|
|
|
|
for (const fn of [
|
|
(z, cb) => {
|
|
z.reset();
|
|
cb();
|
|
},
|
|
(z, cb) => z.params(0, zlib.constants.Z_DEFAULT_STRATEGY, cb),
|
|
]) {
|
|
const deflate = zlib.createDeflate();
|
|
const inflate = zlib.createInflate();
|
|
|
|
deflate.pipe(inflate);
|
|
|
|
const output = [];
|
|
inflate
|
|
.on('error', (err) => {
|
|
assert.ifError(err);
|
|
})
|
|
.on('data', (chunk) => output.push(chunk))
|
|
.on('end', common.mustCall(
|
|
() => assert.strictEqual(Buffer.concat(output).toString(), 'abc')));
|
|
|
|
fn(deflate, () => {
|
|
fn(inflate, () => {
|
|
deflate.write('abc');
|
|
deflate.end();
|
|
});
|
|
});
|
|
}
|