mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 07:51:12 +00:00
f3eb224c83
* Update the user timing implementation to conform to User Timing Level 3. * Reimplement user timing and timerify with pure JavaScript implementations * Simplify the C++ implementation for gc and http2 perf * Runtime deprecate additional perf entry properties in favor of the standard detail argument * Disable the `buffered` option on PerformanceObserver, all entries are queued and dispatched on setImmediate. Only entries with active observers are buffered. * This does remove the user timing and timerify trace events. Because the trace_events are still considered experimental, those can be removed without a deprecation cycle. They are removed to improve performance and reduce complexity. Old: `perf_hooks/usertiming.js n=100000: 92,378.01249733355` New: perf_hooks/usertiming.js n=100000: 270,393.5280638482` PR-URL: https://github.com/nodejs/node/pull/37136 Refs: https://github.com/nodejs/diagnostics/issues/464 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
67 lines
1.6 KiB
JavaScript
67 lines
1.6 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
|
|
common.skipIfInspectorDisabled();
|
|
common.skipIfWorker(); // https://github.com/nodejs/node/issues/22767
|
|
|
|
const { internalBinding } = require('internal/test/binding');
|
|
|
|
const {
|
|
trace: {
|
|
TRACE_EVENT_PHASE_NESTABLE_ASYNC_BEGIN: kBeforeEvent
|
|
}
|
|
} = internalBinding('constants');
|
|
|
|
const { trace } = internalBinding('trace_events');
|
|
|
|
const assert = require('assert');
|
|
const { Session } = require('inspector');
|
|
|
|
const session = new Session();
|
|
|
|
function post(message, data) {
|
|
return new Promise((resolve, reject) => {
|
|
session.post(message, data, (err, result) => {
|
|
if (err)
|
|
reject(new Error(JSON.stringify(err)));
|
|
else
|
|
resolve(result);
|
|
});
|
|
});
|
|
}
|
|
|
|
async function test() {
|
|
session.connect();
|
|
|
|
const events = [];
|
|
let tracingComplete = false;
|
|
session.on('NodeTracing.dataCollected', (n) => {
|
|
assert.ok(n && n.params && n.params.value);
|
|
events.push(...n.params.value); // append the events.
|
|
});
|
|
session.on('NodeTracing.tracingComplete', () => tracingComplete = true);
|
|
|
|
trace(kBeforeEvent, 'foo', 'test1', 0, 'test');
|
|
|
|
const traceConfig = { includedCategories: ['foo'] };
|
|
await post('NodeTracing.start', { traceConfig });
|
|
|
|
trace(kBeforeEvent, 'foo', 'test2', 0, 'test');
|
|
trace(kBeforeEvent, 'bar', 'test3', 0, 'test');
|
|
|
|
await post('NodeTracing.stop', { traceConfig });
|
|
|
|
trace(kBeforeEvent, 'foo', 'test4', 0, 'test');
|
|
session.disconnect();
|
|
|
|
assert.ok(tracingComplete);
|
|
|
|
const marks = events.filter((t) => null !== /foo/.exec(t.cat));
|
|
assert.strictEqual(marks.length, 1);
|
|
assert.strictEqual(marks[0].name, 'test2');
|
|
}
|
|
|
|
test();
|