mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 16:34:41 +00:00
9cde7a033e
In the manual page, there is a statement that ciphersuites contain explicit default settings - all TLS 1.3 ciphersuites enabled. In node, we assume that an empty setting mean no ciphersuites and we disable TLS 1.3. A correct approach to disabling TLS 1.3 is to disable TLS 1.3 and by not override the default ciphersuits with an empty string. So, only override OpenSSL's TLS 1.3 ciphersuites with an explicit list of ciphers. If none are acceptable, the correct approach is to disable TLS 1.3 instead elsewhere. Fixes: https://github.com/nodejs/node/issues/43419 PR-URL: https://github.com/nodejs/node/pull/43427 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com>
99 lines
3.3 KiB
JavaScript
99 lines
3.3 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const tls = require('tls');
|
|
// Import fixtures directly from its module
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const options = {
|
|
key: fixtures.readKey('agent2-key.pem'),
|
|
cert: fixtures.readKey('agent2-cert.pem'),
|
|
honorCipherOrder: true
|
|
};
|
|
|
|
let clients = 0;
|
|
const server = tls.createServer(options, common.mustCall(() => {
|
|
if (--clients === 0)
|
|
server.close();
|
|
}, 2));
|
|
|
|
server.listen(0, '127.0.0.1', common.mustCall(function() {
|
|
clients++;
|
|
tls.connect({
|
|
host: '127.0.0.1',
|
|
port: this.address().port,
|
|
ciphers: 'AES128-SHA256',
|
|
rejectUnauthorized: false,
|
|
maxVersion: 'TLSv1.2',
|
|
}, common.mustCall(function() {
|
|
const cipher = this.getCipher();
|
|
assert.strictEqual(cipher.name, 'AES128-SHA256');
|
|
assert.strictEqual(cipher.standardName, 'TLS_RSA_WITH_AES_128_CBC_SHA256');
|
|
assert.strictEqual(cipher.version, 'TLSv1.2');
|
|
this.end();
|
|
}));
|
|
|
|
clients++;
|
|
tls.connect({
|
|
host: '127.0.0.1',
|
|
port: this.address().port,
|
|
ciphers: 'ECDHE-RSA-AES128-GCM-SHA256',
|
|
rejectUnauthorized: false,
|
|
maxVersion: 'TLSv1.2',
|
|
}, common.mustCall(function() {
|
|
const cipher = this.getCipher();
|
|
assert.strictEqual(cipher.name, 'ECDHE-RSA-AES128-GCM-SHA256');
|
|
assert.strictEqual(cipher.standardName,
|
|
'TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256');
|
|
assert.strictEqual(cipher.version, 'TLSv1.2');
|
|
this.end();
|
|
}));
|
|
}));
|
|
|
|
tls.createServer({
|
|
key: fixtures.readKey('agent2-key.pem'),
|
|
cert: fixtures.readKey('agent2-cert.pem'),
|
|
ciphers: 'TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_CCM_8_SHA256',
|
|
maxVersion: 'TLSv1.3',
|
|
}, common.mustCall(function() {
|
|
this.close();
|
|
})).listen(0, common.mustCall(function() {
|
|
const client = tls.connect({
|
|
port: this.address().port,
|
|
ciphers: 'TLS_AES_128_CCM_8_SHA256',
|
|
maxVersion: 'TLSv1.3',
|
|
rejectUnauthorized: false
|
|
}, common.mustCall(() => {
|
|
const cipher = client.getCipher();
|
|
assert.strictEqual(cipher.name, 'TLS_AES_128_CCM_8_SHA256');
|
|
assert.strictEqual(cipher.standardName, cipher.name);
|
|
assert.strictEqual(cipher.version, 'TLSv1.3');
|
|
client.end();
|
|
}));
|
|
}));
|