node/test/parallel/test-stream-readable-pause-and-resume.js
Robert Nagy 224b78ff06
stream: resume stream on drain
Previously we would just resume "flowing" the stream without
reseting the "paused" state. Fixes this by properly using
pause/resume methods for .pipe.

Fixes: https://github.com/nodejs/node/issues/41785

PR-URL: https://github.com/nodejs/node/pull/41848
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2022-02-06 10:05:51 +00:00

75 lines
1.5 KiB
JavaScript

'use strict';
const common = require('../common');
const assert = require('assert');
const { Readable } = require('stream');
let ticks = 18;
let expectedData = 19;
const rs = new Readable({
objectMode: true,
read: () => {
if (ticks-- > 0)
return process.nextTick(() => rs.push({}));
rs.push({});
rs.push(null);
}
});
rs.on('end', common.mustCall());
readAndPause();
function readAndPause() {
// Does a on(data) -> pause -> wait -> resume -> on(data) ... loop.
// Expects on(data) to never fire if the stream is paused.
const ondata = common.mustCall((data) => {
rs.pause();
expectedData--;
if (expectedData <= 0)
return;
setImmediate(function() {
rs.removeListener('data', ondata);
readAndPause();
rs.resume();
});
}, 1); // Only call ondata once
rs.on('data', ondata);
}
{
const readable = new Readable({
read() {}
});
function read() {}
readable.setEncoding('utf8');
readable.on('readable', read);
readable.removeListener('readable', read);
readable.pause();
process.nextTick(function() {
assert(readable.isPaused());
});
}
{
const { PassThrough } = require('stream');
const source3 = new PassThrough();
const target3 = new PassThrough();
const chunk = Buffer.allocUnsafe(1000);
while (target3.write(chunk));
source3.pipe(target3);
target3.on('drain', common.mustCall(() => {
assert(!source3.isPaused());
}));
target3.on('data', () => {});
}