mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 09:23:11 +00:00
e7cb694a60
The complicated `awaitDrain` machinery can be made a bit
slimmer, and more correct, by just resetting the value
each time `stream.emit('data')` is called.
By resetting the value before emitting the data chunk, and
seeing whether any pipe destinations return `.write() === false`,
we always end up in a consistent state and don’t need to worry
about odd situations (like `dest.write(chunk)` emitting more data).
PR-URL: https://github.com/nodejs/node/pull/18516
Fixes: https://github.com/nodejs/node/issues/18484
Fixes: https://github.com/nodejs/node/issues/18512
Refs: https://github.com/nodejs/node/pull/18515
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
36 lines
762 B
JavaScript
36 lines
762 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const stream = require('stream');
|
|
|
|
function test(throwCodeInbetween) {
|
|
// Check that a pipe does not stall if .read() is called unexpectedly
|
|
// (i.e. the stream is not resumed by the pipe).
|
|
|
|
const n = 1000;
|
|
let counter = n;
|
|
const rs = stream.Readable({
|
|
objectMode: true,
|
|
read: common.mustCallAtLeast(() => {
|
|
if (--counter >= 0)
|
|
rs.push({ counter });
|
|
else
|
|
rs.push(null);
|
|
}, n)
|
|
});
|
|
|
|
const ws = stream.Writable({
|
|
objectMode: true,
|
|
write: common.mustCall((data, enc, cb) => {
|
|
setImmediate(cb);
|
|
}, n)
|
|
});
|
|
|
|
setImmediate(() => throwCodeInbetween(rs, ws));
|
|
|
|
rs.pipe(ws);
|
|
}
|
|
|
|
test((rs) => rs.read());
|
|
test((rs) => rs.resume());
|
|
test(() => 0);
|