mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 16:34:41 +00:00

Make `response.setHeader` return the response object itself so that multiple header setting can be chained. Fixes: https://github.com/nodejs/node/issues/33148 PR-URL: https://github.com/nodejs/node/pull/35924 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
30 lines
857 B
JavaScript
30 lines
857 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const http = require('http');
|
|
const assert = require('assert');
|
|
const expected = {
|
|
'__proto__': null,
|
|
'testheader1': 'foo',
|
|
'testheader2': 'bar',
|
|
'testheader3': 'xyz'
|
|
};
|
|
const server = http.createServer(common.mustCall((req, res) => {
|
|
let retval = res.setHeader('testheader1', 'foo');
|
|
|
|
// Test that the setHeader returns the same response object.
|
|
assert.strictEqual(retval, res);
|
|
|
|
retval = res.setHeader('testheader2', 'bar').setHeader('testheader3', 'xyz');
|
|
// Test that chaining works for setHeader.
|
|
assert.deepStrictEqual(res.getHeaders(), expected);
|
|
res.end('ok');
|
|
}));
|
|
server.listen(0, () => {
|
|
http.get({ port: server.address().port }, common.mustCall((res) => {
|
|
res.on('data', () => {});
|
|
res.on('end', common.mustCall(() => {
|
|
server.close();
|
|
}));
|
|
}));
|
|
});
|