mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 11:12:55 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
43 lines
1.3 KiB
JavaScript
43 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
|
|
// All of these values should cause http.request() to throw synchronously
|
|
// when passed as the value of either options.hostname or options.host
|
|
const vals = [{}, [], NaN, Infinity, -Infinity, true, false, 1, 0, new Date()];
|
|
|
|
vals.forEach((v) => {
|
|
const received = common.invalidArgTypeHelper(v);
|
|
assert.throws(
|
|
() => http.request({ hostname: v }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "options.hostname" property must be of ' +
|
|
'type string or one of undefined or null.' +
|
|
received
|
|
}
|
|
);
|
|
|
|
assert.throws(
|
|
() => http.request({ host: v }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "options.host" property must be of ' +
|
|
'type string or one of undefined or null.' +
|
|
received
|
|
}
|
|
);
|
|
});
|
|
|
|
// These values are OK and should not throw synchronously.
|
|
// Only testing for 'hostname' validation so ignore connection errors.
|
|
const dontCare = () => {};
|
|
['', undefined, null].forEach((v) => {
|
|
http.request({ hostname: v }).on('error', dontCare).end();
|
|
http.request({ host: v }).on('error', dontCare).end();
|
|
});
|