mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 07:51:12 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
33 lines
790 B
JavaScript
33 lines
790 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const EventEmitter = require('events');
|
|
|
|
const EE = new EventEmitter();
|
|
const theErr = new Error('MyError');
|
|
|
|
EE.on(
|
|
EventEmitter.errorMonitor,
|
|
common.mustCall(function onErrorMonitor(e) {
|
|
assert.strictEqual(e, theErr);
|
|
}, 3)
|
|
);
|
|
|
|
// Verify with no error listener
|
|
assert.throws(
|
|
() => EE.emit('error', theErr), theErr
|
|
);
|
|
|
|
// Verify with error listener
|
|
EE.once('error', common.mustCall((e) => assert.strictEqual(e, theErr)));
|
|
EE.emit('error', theErr);
|
|
|
|
|
|
// Verify it works with once
|
|
process.nextTick(() => EE.emit('error', theErr));
|
|
assert.rejects(EventEmitter.once(EE, 'notTriggered'), theErr);
|
|
|
|
// Only error events trigger error monitor
|
|
EE.on('aEvent', common.mustCall());
|
|
EE.emit('aEvent');
|