node/test/parallel/test-eslint-prefer-proto.js
Jordan Harband 757c104147
tools: add prefer-proto rule
fixup: add support for `Object.create(null)`

fixup: extend to any 1-argument Object.create call

fixup: add tests
PR-URL: https://github.com/nodejs/node/pull/46083
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2023-01-10 05:38:36 +00:00

72 lines
2.0 KiB
JavaScript

'use strict';
const common = require('../common');
if ((!common.hasCrypto) || (!common.hasIntl)) {
common.skip('ESLint tests require crypto and Intl');
}
common.skipIfEslintMissing();
const RuleTester = require('../../tools/node_modules/eslint').RuleTester;
const rule = require('../../tools/eslint-rules/prefer-proto');
new RuleTester({
parserOptions: { ecmaVersion: 2022 }
}).run('prefer-common-mustsucceed', rule, {
valid: [
'({ __proto__: null })',
'const x = { __proto__: null };',
`
class X {
field = { __proto__: null };
constructor() {
this.x = { __proto__: X };
}
}
`,
'foo({ __proto__: Array.prototype })',
'({ "__proto__": null })',
"({ '__proto__': null })",
'ObjectCreate(null, undefined)',
'Object.create(null, undefined)',
'Object.create(null, undefined, undefined)',
'ObjectCreate(null, descriptors)',
'Object.create(null, descriptors)',
'ObjectCreate(Foo.prototype, descriptors)',
'Object.create(Foo.prototype, descriptors)',
],
invalid: [
{
code: 'ObjectCreate(null)',
output: '{ __proto__: null }',
errors: [{ messageId: 'error', data: { value: 'null' } }],
},
{
code: 'Object.create(null)',
output: '{ __proto__: null }',
errors: [{ messageId: 'error', data: { value: 'null' } }],
},
{
code: 'ObjectCreate(null,)',
output: '{ __proto__: null }',
errors: [{ messageId: 'error', data: { value: 'null' } }],
},
{
code: 'Object.create(null,)',
output: '{ __proto__: null }',
errors: [{ messageId: 'error', data: { value: 'null' } }],
},
{
code: 'ObjectCreate(Foo)',
output: '{ __proto__: Foo }',
errors: [{ messageId: 'error', data: { value: 'Foo' } }],
},
{
code: 'Object.create(Foo)',
output: '{ __proto__: Foo }',
errors: [{ messageId: 'error', data: { value: 'Foo' } }],
},
]
});