mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 16:34:41 +00:00
e0fb3f7cb8
Locally this speeds up running test-crypto-dh* from 7s to 2s. This was previously timing out in CI (took more than 2 minutes) so should see a bigger gap in the CI. PR-URL: https://github.com/nodejs/node/pull/49492 Refs: https://github.com/nodejs/node/issues/49202 Refs: https://github.com/nodejs/reliability/issues/655 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
112 lines
2.8 KiB
JavaScript
112 lines
2.8 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const crypto = require('crypto');
|
|
|
|
// https://github.com/nodejs/node/issues/32738
|
|
// XXX(bnoordhuis) validateInt32() throwing ERR_OUT_OF_RANGE and RangeError
|
|
// instead of ERR_INVALID_ARG_TYPE and TypeError is questionable, IMO.
|
|
assert.throws(() => crypto.createDiffieHellman(13.37), {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "sizeOrKey" is out of range. ' +
|
|
'It must be an integer. Received 13.37',
|
|
});
|
|
|
|
assert.throws(() => crypto.createDiffieHellman('abcdef', 13.37), {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "generator" is out of range. ' +
|
|
'It must be an integer. Received 13.37',
|
|
});
|
|
|
|
for (const bits of [-1, 0, 1]) {
|
|
if (common.hasOpenSSL3) {
|
|
assert.throws(() => crypto.createDiffieHellman(bits), {
|
|
code: 'ERR_OSSL_DH_MODULUS_TOO_SMALL',
|
|
name: 'Error',
|
|
message: /modulus too small/,
|
|
});
|
|
} else {
|
|
assert.throws(() => crypto.createDiffieHellman(bits), {
|
|
code: 'ERR_OSSL_BN_BITS_TOO_SMALL',
|
|
name: 'Error',
|
|
message: /bits too small/,
|
|
});
|
|
}
|
|
}
|
|
|
|
for (const g of [-1, 1]) {
|
|
const ex = {
|
|
code: 'ERR_OSSL_DH_BAD_GENERATOR',
|
|
name: 'Error',
|
|
message: /bad generator/,
|
|
};
|
|
assert.throws(() => crypto.createDiffieHellman('abcdef', g), ex);
|
|
assert.throws(() => crypto.createDiffieHellman('abcdef', 'hex', g), ex);
|
|
}
|
|
|
|
for (const g of [Buffer.from([]),
|
|
Buffer.from([0]),
|
|
Buffer.from([1])]) {
|
|
const ex = {
|
|
code: 'ERR_OSSL_DH_BAD_GENERATOR',
|
|
name: 'Error',
|
|
message: /bad generator/,
|
|
};
|
|
assert.throws(() => crypto.createDiffieHellman('abcdef', g), ex);
|
|
assert.throws(() => crypto.createDiffieHellman('abcdef', 'hex', g), ex);
|
|
}
|
|
|
|
[
|
|
[0x1, 0x2],
|
|
() => { },
|
|
/abc/,
|
|
{},
|
|
].forEach((input) => {
|
|
assert.throws(
|
|
() => crypto.createDiffieHellman(input),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
}
|
|
);
|
|
});
|
|
|
|
// Invalid test: curve argument is undefined
|
|
assert.throws(
|
|
() => crypto.createECDH(),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "curve" argument must be of type string. ' +
|
|
'Received undefined'
|
|
});
|
|
|
|
assert.throws(
|
|
function() {
|
|
crypto.getDiffieHellman('unknown-group');
|
|
},
|
|
{
|
|
name: 'Error',
|
|
code: 'ERR_CRYPTO_UNKNOWN_DH_GROUP',
|
|
message: 'Unknown DH group'
|
|
},
|
|
'crypto.getDiffieHellman(\'unknown-group\') ' +
|
|
'failed to throw the expected error.'
|
|
);
|
|
|
|
assert.throws(
|
|
() => crypto.createDiffieHellman('', true),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE'
|
|
}
|
|
);
|
|
[true, Symbol(), {}, () => {}, []].forEach((generator) => assert.throws(
|
|
() => crypto.createDiffieHellman('', 'base64', generator),
|
|
{ code: 'ERR_INVALID_ARG_TYPE' }
|
|
));
|