mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 14:25:18 +00:00
a13500f503
This fixes a few bugs in `fs`. E.g., `fs.promises.access` accepted strings as mode. It should have only accepted numbers. It will now always validate the flags and the mode argument in an consistent way. PR-URL: https://github.com/nodejs/node/pull/27044 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
38 lines
1.0 KiB
JavaScript
38 lines
1.0 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const fixtures = require('../common/fixtures');
|
|
const tmpdir = require('../common/tmpdir');
|
|
|
|
const { access, copyFile, open } = require('fs').promises;
|
|
const path = require('path');
|
|
|
|
async function validate() {
|
|
tmpdir.refresh();
|
|
const dest = path.resolve(tmpdir.path, 'baz.js');
|
|
await assert.rejects(
|
|
copyFile(fixtures.path('baz.js'), dest, 'r'),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: /mode.*integer.*string/
|
|
}
|
|
);
|
|
await copyFile(fixtures.path('baz.js'), dest);
|
|
await assert.rejects(
|
|
access(dest, 'r'),
|
|
{ code: 'ERR_INVALID_ARG_TYPE', message: /mode/ }
|
|
);
|
|
await access(dest);
|
|
const handle = await open(dest, 'r+');
|
|
await handle.datasync();
|
|
await handle.sync();
|
|
const buf = Buffer.from('hello world');
|
|
await handle.write(buf);
|
|
const ret = await handle.read(Buffer.alloc(11), 0, 11, 0);
|
|
assert.strictEqual(ret.bytesRead, 11);
|
|
assert.deepStrictEqual(ret.buffer, buf);
|
|
await handle.close();
|
|
}
|
|
|
|
validate();
|