mirror of
https://github.com/nodejs/node.git
synced 2025-05-11 03:34:30 +00:00
9f3d59eabb
* eliminate pooling of Nghttp2Stream instances. After testing, the pooling is not having any tangible benefit and makes things more complicated. Simplify. Simplify. * refactor inbound headers * Enforce MAX_HEADERS_LIST setting and limit the number of header pairs accepted from the peer. Use the ENHANCE_YOUR_CALM error code when receiving either too many headers or too many octets. Use a vector to store the headers instead of a queue PR-URL: https://github.com/nodejs/node/pull/16676 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
75 lines
2.7 KiB
JavaScript
75 lines
2.7 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
|
|
require('../common');
|
|
|
|
// Test coverage for the updateOptionsBuffer method used internally
|
|
// by the http2 implementation.
|
|
|
|
const { updateOptionsBuffer } = require('internal/http2/util');
|
|
const { optionsBuffer } = process.binding('http2');
|
|
const { ok, strictEqual } = require('assert');
|
|
|
|
const IDX_OPTIONS_MAX_DEFLATE_DYNAMIC_TABLE_SIZE = 0;
|
|
const IDX_OPTIONS_MAX_RESERVED_REMOTE_STREAMS = 1;
|
|
const IDX_OPTIONS_MAX_SEND_HEADER_BLOCK_LENGTH = 2;
|
|
const IDX_OPTIONS_PEER_MAX_CONCURRENT_STREAMS = 3;
|
|
const IDX_OPTIONS_PADDING_STRATEGY = 4;
|
|
const IDX_OPTIONS_MAX_HEADER_LIST_PAIRS = 5;
|
|
const IDX_OPTIONS_FLAGS = 6;
|
|
|
|
{
|
|
updateOptionsBuffer({
|
|
maxDeflateDynamicTableSize: 1,
|
|
maxReservedRemoteStreams: 2,
|
|
maxSendHeaderBlockLength: 3,
|
|
peerMaxConcurrentStreams: 4,
|
|
paddingStrategy: 5,
|
|
maxHeaderListPairs: 6
|
|
});
|
|
|
|
strictEqual(optionsBuffer[IDX_OPTIONS_MAX_DEFLATE_DYNAMIC_TABLE_SIZE], 1);
|
|
strictEqual(optionsBuffer[IDX_OPTIONS_MAX_RESERVED_REMOTE_STREAMS], 2);
|
|
strictEqual(optionsBuffer[IDX_OPTIONS_MAX_SEND_HEADER_BLOCK_LENGTH], 3);
|
|
strictEqual(optionsBuffer[IDX_OPTIONS_PEER_MAX_CONCURRENT_STREAMS], 4);
|
|
strictEqual(optionsBuffer[IDX_OPTIONS_PADDING_STRATEGY], 5);
|
|
strictEqual(optionsBuffer[IDX_OPTIONS_MAX_HEADER_LIST_PAIRS], 6);
|
|
|
|
const flags = optionsBuffer[IDX_OPTIONS_FLAGS];
|
|
|
|
ok(flags & (1 << IDX_OPTIONS_MAX_DEFLATE_DYNAMIC_TABLE_SIZE));
|
|
ok(flags & (1 << IDX_OPTIONS_MAX_RESERVED_REMOTE_STREAMS));
|
|
ok(flags & (1 << IDX_OPTIONS_MAX_SEND_HEADER_BLOCK_LENGTH));
|
|
ok(flags & (1 << IDX_OPTIONS_PEER_MAX_CONCURRENT_STREAMS));
|
|
ok(flags & (1 << IDX_OPTIONS_PADDING_STRATEGY));
|
|
ok(flags & (1 << IDX_OPTIONS_MAX_HEADER_LIST_PAIRS));
|
|
}
|
|
|
|
{
|
|
optionsBuffer[IDX_OPTIONS_MAX_SEND_HEADER_BLOCK_LENGTH] = 0;
|
|
|
|
updateOptionsBuffer({
|
|
maxDeflateDynamicTableSize: 1,
|
|
maxReservedRemoteStreams: 2,
|
|
peerMaxConcurrentStreams: 4,
|
|
paddingStrategy: 5,
|
|
maxHeaderListPairs: 6
|
|
});
|
|
|
|
strictEqual(optionsBuffer[IDX_OPTIONS_MAX_DEFLATE_DYNAMIC_TABLE_SIZE], 1);
|
|
strictEqual(optionsBuffer[IDX_OPTIONS_MAX_RESERVED_REMOTE_STREAMS], 2);
|
|
strictEqual(optionsBuffer[IDX_OPTIONS_MAX_SEND_HEADER_BLOCK_LENGTH], 0);
|
|
strictEqual(optionsBuffer[IDX_OPTIONS_PEER_MAX_CONCURRENT_STREAMS], 4);
|
|
strictEqual(optionsBuffer[IDX_OPTIONS_PADDING_STRATEGY], 5);
|
|
strictEqual(optionsBuffer[IDX_OPTIONS_MAX_HEADER_LIST_PAIRS], 6);
|
|
|
|
const flags = optionsBuffer[IDX_OPTIONS_FLAGS];
|
|
|
|
ok(flags & (1 << IDX_OPTIONS_MAX_DEFLATE_DYNAMIC_TABLE_SIZE));
|
|
ok(flags & (1 << IDX_OPTIONS_MAX_RESERVED_REMOTE_STREAMS));
|
|
ok(!(flags & (1 << IDX_OPTIONS_MAX_SEND_HEADER_BLOCK_LENGTH)));
|
|
ok(flags & (1 << IDX_OPTIONS_PEER_MAX_CONCURRENT_STREAMS));
|
|
ok(flags & (1 << IDX_OPTIONS_PADDING_STRATEGY));
|
|
ok(flags & (1 << IDX_OPTIONS_MAX_HEADER_LIST_PAIRS));
|
|
}
|