node/test/parallel/test-stream-writable-end-cb-error.js
Robert Nagy 9d09969f4c
stream: always invoke end callback
Ensure that the callback passed into end() is always invoke in
order to avoid bug such as deadlock the user.

PR-URL: https://github.com/nodejs/node/pull/29747
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2019-11-19 16:06:35 +01:00

49 lines
1.1 KiB
JavaScript

'use strict';
const common = require('../common');
const assert = require('assert');
const stream = require('stream');
{
// Invoke end callback on failure.
const writable = new stream.Writable();
writable._write = (chunk, encoding, cb) => {
process.nextTick(cb, new Error('kaboom'));
};
writable.on('error', common.mustCall((err) => {
assert.strictEqual(err.message, 'kaboom');
}));
writable.write('asd');
writable.end(common.mustCall((err) => {
assert.strictEqual(err.message, 'kaboom');
}));
writable.end(common.mustCall((err) => {
assert.strictEqual(err.message, 'kaboom');
}));
}
{
// Don't invoke end callback twice
const writable = new stream.Writable();
writable._write = (chunk, encoding, cb) => {
process.nextTick(cb);
};
let called = false;
writable.end('asd', common.mustCall((err) => {
called = true;
assert.strictEqual(err, undefined);
}));
writable.on('error', common.mustCall((err) => {
assert.strictEqual(err.message, 'kaboom');
}));
writable.on('finish', common.mustCall(() => {
assert.strictEqual(called, true);
writable.emit('error', new Error('kaboom'));
}));
}