mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 08:42:45 +00:00

This commit adds support for async createConnection() implementations and is still backwards compatible with synchronous createConnection() implementations. This commit also makes the http client more friendly with generic stream objects produced by createConnection() by checking stream.writable instead of stream.destroyed as the latter is currently a net.Socket-ism and not set by the core stream implementations. PR-URL: https://github.com/nodejs/node/pull/4638 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
62 lines
1.8 KiB
JavaScript
62 lines
1.8 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const http = require('http');
|
|
const net = require('net');
|
|
const assert = require('assert');
|
|
|
|
const server = http.createServer(common.mustCall(function(req, res) {
|
|
res.end();
|
|
}, 4)).listen(common.PORT, '127.0.0.1', function() {
|
|
let fn = common.mustCall(createConnection);
|
|
http.get({ createConnection: fn }, function(res) {
|
|
res.resume();
|
|
fn = common.mustCall(createConnectionAsync);
|
|
http.get({ createConnection: fn }, function(res) {
|
|
res.resume();
|
|
fn = common.mustCall(createConnectionBoth1);
|
|
http.get({ createConnection: fn }, function(res) {
|
|
res.resume();
|
|
fn = common.mustCall(createConnectionBoth2);
|
|
http.get({ createConnection: fn }, function(res) {
|
|
res.resume();
|
|
fn = common.mustCall(createConnectionError);
|
|
http.get({ createConnection: fn }, function(res) {
|
|
assert.fail(null, null, 'Unexpected response callback');
|
|
}).on('error', common.mustCall(function(err) {
|
|
assert.equal(err.message, 'Could not create socket');
|
|
server.close();
|
|
}));
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
function createConnection() {
|
|
return net.createConnection(common.PORT, '127.0.0.1');
|
|
}
|
|
|
|
function createConnectionAsync(options, cb) {
|
|
setImmediate(function() {
|
|
cb(null, net.createConnection(common.PORT, '127.0.0.1'));
|
|
});
|
|
}
|
|
|
|
function createConnectionBoth1(options, cb) {
|
|
const socket = net.createConnection(common.PORT, '127.0.0.1');
|
|
setImmediate(function() {
|
|
cb(null, socket);
|
|
});
|
|
return socket;
|
|
}
|
|
|
|
function createConnectionBoth2(options, cb) {
|
|
const socket = net.createConnection(common.PORT, '127.0.0.1');
|
|
cb(null, socket);
|
|
return socket;
|
|
}
|
|
|
|
function createConnectionError(options, cb) {
|
|
process.nextTick(cb, new Error('Could not create socket'));
|
|
}
|