mirror of
https://github.com/nodejs/node.git
synced 2025-05-10 10:01:19 +00:00
99b27ce99a
The ES addition operator calls the ToPrimitive() abstract operation without hint String, leading a subsequent OrdinaryToPrimitive() to call valueOf() first on an object rather than the desired toString(). Instead, use template literals which directly call ToString() abstract operation, per Web IDL spec. PR-URL: https://github.com/nodejs/node/pull/11737 Fixes:b610a4db1c"url: enforce valid UTF-8 in WHATWG parser" Refs:b610a4db1c (commitcomment-21200056)Refs: https://tc39.github.io/ecma262/#sec-addition-operator-plus-runtime-semantics-evaluation Refs: https://tc39.github.io/ecma262/#sec-template-literals-runtime-semantics-evaluation Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
73 lines
2.7 KiB
JavaScript
73 lines
2.7 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const URLSearchParams = require('url').URLSearchParams;
|
|
const { test, assert_equals, assert_true } = common.WPT;
|
|
|
|
/* eslint-disable */
|
|
/* WPT Refs:
|
|
https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-append.html
|
|
License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html
|
|
*/
|
|
test(function() {
|
|
var params = new URLSearchParams();
|
|
params.append('a', 'b');
|
|
assert_equals(params + '', 'a=b');
|
|
params.append('a', 'b');
|
|
assert_equals(params + '', 'a=b&a=b');
|
|
params.append('a', 'c');
|
|
assert_equals(params + '', 'a=b&a=b&a=c');
|
|
}, 'Append same name');
|
|
test(function() {
|
|
var params = new URLSearchParams();
|
|
params.append('', '');
|
|
assert_equals(params + '', '=');
|
|
params.append('', '');
|
|
assert_equals(params + '', '=&=');
|
|
}, 'Append empty strings');
|
|
test(function() {
|
|
var params = new URLSearchParams();
|
|
params.append(null, null);
|
|
assert_equals(params + '', 'null=null');
|
|
params.append(null, null);
|
|
assert_equals(params + '', 'null=null&null=null');
|
|
}, 'Append null');
|
|
test(function() {
|
|
var params = new URLSearchParams();
|
|
params.append('first', 1);
|
|
params.append('second', 2);
|
|
params.append('third', '');
|
|
params.append('first', 10);
|
|
assert_true(params.has('first'), 'Search params object has name "first"');
|
|
assert_equals(params.get('first'), '1', 'Search params object has name "first" with value "1"');
|
|
assert_equals(params.get('second'), '2', 'Search params object has name "second" with value "2"');
|
|
assert_equals(params.get('third'), '', 'Search params object has name "third" with value ""');
|
|
params.append('first', 10);
|
|
assert_equals(params.get('first'), '1', 'Search params object has name "first" with value "1"');
|
|
}, 'Append multiple');
|
|
/* eslint-enable */
|
|
|
|
// Tests below are not from WPT.
|
|
{
|
|
const params = new URLSearchParams();
|
|
assert.throws(() => {
|
|
params.append.call(undefined);
|
|
}, /^TypeError: Value of `this` is not a URLSearchParams$/);
|
|
assert.throws(() => {
|
|
params.set('a');
|
|
}, /^TypeError: "name" and "value" arguments must be specified$/);
|
|
|
|
const obj = {
|
|
toString() { throw new Error('toString'); },
|
|
valueOf() { throw new Error('valueOf'); }
|
|
};
|
|
const sym = Symbol();
|
|
assert.throws(() => params.set(obj, 'b'), /^Error: toString$/);
|
|
assert.throws(() => params.set('a', obj), /^Error: toString$/);
|
|
assert.throws(() => params.set(sym, 'b'),
|
|
/^TypeError: Cannot convert a Symbol value to a string$/);
|
|
assert.throws(() => params.set('a', sym),
|
|
/^TypeError: Cannot convert a Symbol value to a string$/);
|
|
}
|