mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 23:56:58 +00:00
97f76f3f04
There are a few places where tests repeatedly concatenate strings to
themselves in order to make them very long. Using `.repeat()` makes the
code clearer.
For example, before:
for (var i = 0; i < 8; ++i) lots_of_headers += lots_of_headers;
After:
lots_of_headers = lots_of_headers.repeat(256);
Using `.repeat()` makes it clear that the string will be repeated 256
times rather than 8 times. ("What?! That first one doesn't repeat 256
times! It only repeats 8... Oh, wait. Yes, I see your point now.")
PR-URL: https://github.com/nodejs/node/pull/5311
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
43 lines
1000 B
JavaScript
43 lines
1000 B
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
var http = require('http');
|
|
|
|
if (common.hasCrypto) {
|
|
var https = require('https');
|
|
} else {
|
|
console.log('1..0 # Skipped: missing crypto');
|
|
}
|
|
|
|
var host = '*'.repeat(256);
|
|
|
|
function do_not_call() {
|
|
throw new Error('This function should not have been called.');
|
|
}
|
|
|
|
function test(mod) {
|
|
|
|
// Bad host name should not throw an uncatchable exception.
|
|
// Ensure that there is time to attach an error listener.
|
|
var req1 = mod.get({host: host, port: 42}, do_not_call);
|
|
req1.on('error', common.mustCall(function(err) {
|
|
assert.equal(err.code, 'ENOTFOUND');
|
|
}));
|
|
// http.get() called req1.end() for us
|
|
|
|
var req2 = mod.request({method: 'GET', host: host, port: 42}, do_not_call);
|
|
req2.on('error', common.mustCall(function(err) {
|
|
assert.equal(err.code, 'ENOTFOUND');
|
|
}));
|
|
req2.end();
|
|
}
|
|
|
|
if (common.hasCrypto) {
|
|
test(https);
|
|
} else {
|
|
console.log('1..0 # Skipped: missing crypto');
|
|
}
|
|
|
|
test(http);
|