mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 14:52:19 +00:00
96a9439fd2
This reverts commit 9bb5a5e2a1.
This API is not suitable because it depended on being able to
potentially access the handle's flag after the handle was already
cleaned up. Since this is not actually possible (obviously, oops)
this newer API no longer makes much sense, and the older API is more
suitable.
API comparison:
IsRefed -> Has a strong reference AND is alive. (Deterministic)
Unrefed -> Has a weak reference OR is dead. (Less deterministic)
Refs: https://github.com/nodejs/node/pull/6395
Refs: https://github.com/nodejs/node/pull/6204
Refs: https://github.com/nodejs/node/pull/6401
Refs: https://github.com/nodejs/node/pull/6382
Fixes: https://github.com/nodejs/node/pull/6381
PR-URL: https://github.com/nodejs/node/pull/6546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Conflicts:
src/handle_wrap.cc
test/parallel/test-handle-wrap-isrefed-tty.js
test/parallel/test-handle-wrap-isrefed.js
34 lines
1.1 KiB
JavaScript
34 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const strictEqual = require('assert').strictEqual;
|
|
const spawn = require('child_process').spawn;
|
|
|
|
function makeAssert(message) {
|
|
return function(actual, expected) {
|
|
strictEqual(actual, expected, message);
|
|
};
|
|
}
|
|
const assert = makeAssert('isRefed() not working on tty_wrap');
|
|
|
|
if (process.argv[2] === 'child') {
|
|
// Test tty_wrap in piped child to guarentee stdin being a TTY.
|
|
const ReadStream = require('tty').ReadStream;
|
|
const tty = new ReadStream(0);
|
|
assert(Object.getPrototypeOf(tty._handle).hasOwnProperty('isRefed'), true);
|
|
assert(tty._handle.isRefed(), true);
|
|
tty.unref();
|
|
assert(tty._handle.isRefed(), false);
|
|
tty._handle.close(
|
|
common.mustCall(() => assert(tty._handle.isRefed(), false)));
|
|
return;
|
|
}
|
|
|
|
// Use spawn so that we can be sure that stdin has a _handle property.
|
|
// Refs: https://github.com/nodejs/node/pull/5916
|
|
const proc = spawn(process.execPath, [__filename, 'child'], { stdio: 'pipe' });
|
|
proc.stderr.pipe(process.stderr);
|
|
proc.on('exit', common.mustCall(function(exitCode) {
|
|
process.exitCode = exitCode;
|
|
}));
|