mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 16:46:56 +00:00
96204c3c71
The error provided in this function could come from user code. Thus the error should not be manipulated in any way. The added properties do not seem to provide any actual value either as can not be part of the error. The `hostname` is already set on the error and adding the `host` property with the identical value does not seem right in this case. PR-URL: https://github.com/nodejs/node/pull/26751 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
31 lines
734 B
JavaScript
31 lines
734 B
JavaScript
'use strict';
|
|
|
|
// This tests that the error thrown from net.createConnection
|
|
// comes with host and port properties.
|
|
// See https://github.com/nodejs/node-v0.x-archive/issues/7005
|
|
|
|
const common = require('../common');
|
|
const net = require('net');
|
|
|
|
const { addresses } = require('../common/internet');
|
|
const {
|
|
errorLookupMock,
|
|
mockedErrorCode
|
|
} = require('../common/dns');
|
|
|
|
// Using port 0 as hostname used is already invalid.
|
|
const c = net.createConnection({
|
|
port: 0,
|
|
host: addresses.INVALID_HOST,
|
|
lookup: common.mustCall(errorLookupMock())
|
|
});
|
|
|
|
c.on('connect', common.mustNotCall());
|
|
|
|
c.on('error', common.expectsError({
|
|
code: mockedErrorCode,
|
|
hostname: addresses.INVALID_HOST,
|
|
port: undefined,
|
|
host: undefined
|
|
}));
|