mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 17:32:22 +00:00
90b0538273
Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the tests conform to the standard test structure. - Rename test-regress-GH-9819 to test-crypto-tostring-segfault - Rename test-regress-GH-5051 to test-http-addrequest-localaddress - Rename test-regress-GH-5727 to test-net-listen-invalid-port - Rename test-regress-GH-5927 to test-tty-stdin-pipe - Rename test-regress-GH-6235 to test-v8-global-setter PR-URL: https://github.com/nodejs/node/pull/19275 Refs: https://github.com/nodejs/node/issues/19105 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
39 lines
1.1 KiB
JavaScript
39 lines
1.1 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
|
|
// This test ensures that `addRequest`'s Legacy API accepts `localAddress`
|
|
// correctly instead of accepting `path`.
|
|
// https://github.com/nodejs/node/issues/5051
|
|
|
|
const assert = require('assert');
|
|
const agent = require('http').globalAgent;
|
|
|
|
// small stub just so we can call addRequest directly
|
|
const req = {
|
|
getHeader: () => {}
|
|
};
|
|
|
|
agent.maxSockets = 0;
|
|
|
|
// localAddress is used when naming requests / sockets
|
|
// while using the Legacy API
|
|
// port 8080 is hardcoded since this does not create a network connection
|
|
agent.addRequest(req, 'localhost', 8080, '127.0.0.1');
|
|
assert.strictEqual(Object.keys(agent.requests).length, 1);
|
|
assert.strictEqual(
|
|
Object.keys(agent.requests)[0],
|
|
'localhost:8080:127.0.0.1');
|
|
|
|
// path is *not* used when naming requests / sockets
|
|
// port 8080 is hardcoded since this does not create a network connection
|
|
agent.addRequest(req, {
|
|
host: 'localhost',
|
|
port: 8080,
|
|
localAddress: '127.0.0.1',
|
|
path: '/foo'
|
|
});
|
|
assert.strictEqual(Object.keys(agent.requests).length, 1);
|
|
assert.strictEqual(
|
|
Object.keys(agent.requests)[0],
|
|
'localhost:8080:127.0.0.1');
|