mirror of
https://github.com/nodejs/node.git
synced 2025-05-17 20:06:54 +00:00
8fb4ea9f75
This commit adds a deprecation code to expectWarning and updates the function to check the passed code against the code property on the warning object. Not all warnings have a deprecation code so for those that don't an explicit code of common.noWarnCode is required. Passing this skips the assertion of the code. PR-URL: https://github.com/nodejs/node/pull/19474 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
41 lines
1.4 KiB
JavaScript
41 lines
1.4 KiB
JavaScript
// Flags: --expose_internals
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const internalCp = require('internal/child_process');
|
|
const oldSpawnSync = internalCp.spawnSync;
|
|
|
|
// Verify that customFds is used if stdio is not provided.
|
|
{
|
|
const msg = 'child_process: options.customFds option is deprecated. ' +
|
|
'Use options.stdio instead.';
|
|
common.expectWarning('DeprecationWarning', msg, 'DEP0006');
|
|
|
|
const customFds = [-1, process.stdout.fd, process.stderr.fd];
|
|
internalCp.spawnSync = common.mustCall(function(opts) {
|
|
assert.deepStrictEqual(opts.options.customFds, customFds);
|
|
assert.deepStrictEqual(opts.options.stdio, [
|
|
{ type: 'pipe', readable: true, writable: false },
|
|
{ type: 'fd', fd: process.stdout.fd },
|
|
{ type: 'fd', fd: process.stderr.fd }
|
|
]);
|
|
});
|
|
common.spawnSyncPwd({ customFds });
|
|
internalCp.spawnSync = oldSpawnSync;
|
|
}
|
|
|
|
// Verify that customFds is ignored when stdio is present.
|
|
{
|
|
const customFds = [0, 1, 2];
|
|
internalCp.spawnSync = common.mustCall(function(opts) {
|
|
assert.deepStrictEqual(opts.options.customFds, customFds);
|
|
assert.deepStrictEqual(opts.options.stdio, [
|
|
{ type: 'pipe', readable: true, writable: false },
|
|
{ type: 'pipe', readable: false, writable: true },
|
|
{ type: 'pipe', readable: false, writable: true }
|
|
]);
|
|
});
|
|
common.spawnSyncPwd({ customFds, stdio: 'pipe' });
|
|
internalCp.spawnSync = oldSpawnSync;
|
|
}
|