mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 01:35:51 +00:00
8f4b4f272e
Stream should be destroyed and update state accordingly when the wrapped stream emits error. Does some additional cleanup with future TODOs that might be worth looking into. PR-URL: https://github.com/nodejs/node/pull/34102 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
33 lines
923 B
JavaScript
33 lines
923 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const Readable = require('_stream_readable');
|
|
const EE = require('events').EventEmitter;
|
|
|
|
const oldStream = new EE();
|
|
oldStream.pause = () => {};
|
|
oldStream.resume = () => {};
|
|
|
|
{
|
|
const r = new Readable({ autoDestroy: true })
|
|
.wrap(oldStream)
|
|
.on('error', common.mustCall(() => {
|
|
assert.strictEqual(r._readableState.errorEmitted, true);
|
|
assert.strictEqual(r._readableState.errored, true);
|
|
assert.strictEqual(r.destroyed, true);
|
|
}));
|
|
oldStream.emit('error', new Error());
|
|
}
|
|
|
|
{
|
|
const r = new Readable({ autoDestroy: false })
|
|
.wrap(oldStream)
|
|
.on('error', common.mustCall(() => {
|
|
assert.strictEqual(r._readableState.errorEmitted, true);
|
|
assert.strictEqual(r._readableState.errored, true);
|
|
assert.strictEqual(r.destroyed, false);
|
|
}));
|
|
oldStream.emit('error', new Error());
|
|
}
|