mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 13:40:37 +00:00
8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
58 lines
1.2 KiB
JavaScript
58 lines
1.2 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (common.isWindows) {
|
|
assert.strictEqual(process.setgroups, undefined);
|
|
return;
|
|
}
|
|
|
|
if (!isMainThread) {
|
|
return;
|
|
}
|
|
|
|
assert.throws(
|
|
() => {
|
|
process.setgroups();
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "groups" argument must be an instance of Array. ' +
|
|
'Received undefined'
|
|
}
|
|
);
|
|
|
|
assert.throws(
|
|
() => {
|
|
process.setgroups([1, -1]);
|
|
},
|
|
{
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
}
|
|
);
|
|
|
|
[undefined, null, true, {}, [], () => {}].forEach((val) => {
|
|
assert.throws(
|
|
() => {
|
|
process.setgroups([val]);
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "groups[0]" argument must be ' +
|
|
'one of type number or string.' +
|
|
common.invalidArgTypeHelper(val)
|
|
}
|
|
);
|
|
});
|
|
|
|
assert.throws(() => {
|
|
process.setgroups([1, 'fhqwhgadshgnsdhjsdbkhsdabkfabkveyb']);
|
|
}, {
|
|
code: 'ERR_UNKNOWN_CREDENTIAL',
|
|
message: 'Group identifier does not exist: fhqwhgadshgnsdhjsdbkhsdabkfabkveyb'
|
|
});
|