mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 13:40:37 +00:00
8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
54 lines
1.6 KiB
JavaScript
54 lines
1.6 KiB
JavaScript
// Flags: --permission --allow-fs-read=* --allow-child-process
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread) {
|
|
common.skip('This test only works on a main thread');
|
|
}
|
|
|
|
const assert = require('assert');
|
|
const { spawnSync } = require('child_process');
|
|
|
|
if (!common.isWindows) {
|
|
common.skip('windows UNC path test');
|
|
}
|
|
|
|
{
|
|
const { stdout, status } = spawnSync(process.execPath, [
|
|
'--permission', '--allow-fs-write', 'C:\\\\', '-e',
|
|
'console.log(process.permission.has("fs.write", "C:\\\\"))',
|
|
]);
|
|
assert.strictEqual(stdout.toString(), 'true\n');
|
|
assert.strictEqual(status, 0);
|
|
}
|
|
|
|
{
|
|
const { stdout, status, stderr } = spawnSync(process.execPath, [
|
|
'--permission', '--allow-fs-write="\\\\?\\C:\\"', '-e',
|
|
'console.log(process.permission.has("fs.write", "C:\\\\"))',
|
|
]);
|
|
assert.strictEqual(stdout.toString(), 'false\n', stderr.toString());
|
|
assert.strictEqual(status, 0);
|
|
}
|
|
|
|
{
|
|
const { stdout, status, stderr } = spawnSync(process.execPath, [
|
|
'--permission', '--allow-fs-write', 'C:\\', '-e',
|
|
`const path = require('path');
|
|
console.log(process.permission.has('fs.write', path.toNamespacedPath('C:\\\\')))`,
|
|
]);
|
|
assert.strictEqual(stdout.toString(), 'true\n', stderr.toString());
|
|
assert.strictEqual(status, 0);
|
|
}
|
|
|
|
{
|
|
const { stdout, status, stderr } = spawnSync(process.execPath, [
|
|
'--permission', '--allow-fs-write', 'C:\\*', '-e',
|
|
"console.log(process.permission.has('fs.write', '\\\\\\\\A\\\\C:\\Users'))",
|
|
]);
|
|
assert.strictEqual(stdout.toString(), 'false\n', stderr.toString());
|
|
assert.strictEqual(status, 0);
|
|
}
|