mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 23:56:58 +00:00
8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
109 lines
2.8 KiB
JavaScript
109 lines
2.8 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const fixtures = require('../common/fixtures');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const tmpdir = require('../common/tmpdir');
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
tmpdir.refresh();
|
|
|
|
const url = fixtures.fileURL('a.js');
|
|
|
|
assert(url instanceof URL);
|
|
|
|
// Check that we can pass in a URL object successfully
|
|
fs.readFile(url, common.mustSucceed((data) => {
|
|
assert(Buffer.isBuffer(data));
|
|
}));
|
|
|
|
// Check that using a non file:// URL reports an error
|
|
const httpUrl = new URL('http://example.org');
|
|
|
|
assert.throws(
|
|
() => {
|
|
fs.readFile(httpUrl, common.mustNotCall());
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_URL_SCHEME',
|
|
name: 'TypeError',
|
|
});
|
|
|
|
// pct-encoded characters in the path will be decoded and checked
|
|
if (common.isWindows) {
|
|
// Encoded back and forward slashes are not permitted on windows
|
|
['%2f', '%2F', '%5c', '%5C'].forEach((i) => {
|
|
assert.throws(
|
|
() => {
|
|
fs.readFile(new URL(`file:///c:/tmp/${i}`), common.mustNotCall());
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_FILE_URL_PATH',
|
|
name: 'TypeError',
|
|
}
|
|
);
|
|
});
|
|
assert.throws(
|
|
() => {
|
|
fs.readFile(new URL('file:///c:/tmp/%00test'), common.mustNotCall());
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_ARG_VALUE',
|
|
name: 'TypeError',
|
|
}
|
|
);
|
|
} else {
|
|
// Encoded forward slashes are not permitted on other platforms
|
|
['%2f', '%2F'].forEach((i) => {
|
|
assert.throws(
|
|
() => {
|
|
fs.readFile(new URL(`file:///c:/tmp/${i}`), common.mustNotCall());
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_FILE_URL_PATH',
|
|
name: 'TypeError',
|
|
});
|
|
});
|
|
assert.throws(
|
|
() => {
|
|
fs.readFile(new URL('file://hostname/a/b/c'), common.mustNotCall());
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_FILE_URL_HOST',
|
|
name: 'TypeError',
|
|
}
|
|
);
|
|
assert.throws(
|
|
() => {
|
|
fs.readFile(new URL('file:///tmp/%00test'), common.mustNotCall());
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_ARG_VALUE',
|
|
name: 'TypeError',
|
|
}
|
|
);
|
|
}
|
|
|
|
// Test that strings are interpreted as paths and not as URL
|
|
// Can't use process.chdir in Workers
|
|
// Please avoid testing fs.rmdir('file:') or using it as cleanup
|
|
if (isMainThread && !common.isWindows) {
|
|
const oldCwd = process.cwd();
|
|
process.chdir(tmpdir.path);
|
|
|
|
for (let slashCount = 0; slashCount < 9; slashCount++) {
|
|
const slashes = '/'.repeat(slashCount);
|
|
|
|
const dirname = `file:${slashes}thisDirectoryWasMadeByFailingNodeJSTestSorry/subdir`;
|
|
fs.mkdirSync(dirname, { recursive: true });
|
|
fs.writeFileSync(`${dirname}/file`, `test failed with ${slashCount} slashes`);
|
|
|
|
const expected = fs.readFileSync(tmpdir.resolve(dirname, 'file'));
|
|
const actual = fs.readFileSync(`${dirname}/file`);
|
|
assert.deepStrictEqual(actual, expected);
|
|
}
|
|
|
|
process.chdir(oldCwd);
|
|
}
|