mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 06:19:07 +00:00
8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
108 lines
3.3 KiB
JavaScript
108 lines
3.3 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
if (common.isWindows) {
|
|
common.skip('no signals in Windows');
|
|
}
|
|
const { isMainThread } = require('worker_threads');
|
|
if (!isMainThread) {
|
|
common.skip('No signal handling available in Workers');
|
|
}
|
|
|
|
const assert = require('assert');
|
|
const initHooks = require('./init-hooks');
|
|
const { checkInvocations } = require('./hook-checks');
|
|
const exec = require('child_process').exec;
|
|
|
|
const hooks = initHooks();
|
|
|
|
hooks.enable();
|
|
|
|
// Keep the event loop open so process doesn't exit before receiving signals.
|
|
const interval = setInterval(() => {}, 9999);
|
|
|
|
process.on('SIGUSR2', common.mustCall(onsigusr2, 2));
|
|
|
|
const as = hooks.activitiesOfTypes('SIGNALWRAP');
|
|
assert.strictEqual(as.length, 1);
|
|
const signal1 = as[0];
|
|
assert.strictEqual(signal1.type, 'SIGNALWRAP');
|
|
assert.strictEqual(typeof signal1.uid, 'number');
|
|
assert.strictEqual(typeof signal1.triggerAsyncId, 'number');
|
|
checkInvocations(signal1, { init: 1 }, 'when SIGUSR2 handler is set up');
|
|
|
|
let count = 0;
|
|
exec(`kill -USR2 ${process.pid}`);
|
|
|
|
let signal2;
|
|
|
|
function onsigusr2() {
|
|
count++;
|
|
|
|
if (count === 1) {
|
|
// first invocation
|
|
checkInvocations(
|
|
signal1, { init: 1, before: 1 },
|
|
' signal1: when first SIGUSR2 handler is called for the first time');
|
|
|
|
// Trigger same signal handler again
|
|
exec(`kill -USR2 ${process.pid}`);
|
|
} else {
|
|
// second invocation
|
|
checkInvocations(
|
|
signal1, { init: 1, before: 2, after: 1 },
|
|
'signal1: when first SIGUSR2 handler is called for the second time');
|
|
|
|
// Install another signal handler
|
|
process.removeAllListeners('SIGUSR2');
|
|
process.on('SIGUSR2', common.mustCall(onsigusr2Again));
|
|
|
|
const as = hooks.activitiesOfTypes('SIGNALWRAP');
|
|
// The isTTY checks are needed to allow test to work whether run with
|
|
// test.py or directly with the node executable. The third signal event
|
|
// listener is the SIGWINCH handler that node installs when it thinks
|
|
// process.stdout is a tty.
|
|
const expectedLen = 2 + (!!process.stdout.isTTY || !!process.stderr.isTTY);
|
|
assert.strictEqual(as.length, expectedLen);
|
|
signal2 = as[expectedLen - 1]; // Last item in the array.
|
|
assert.strictEqual(signal2.type, 'SIGNALWRAP');
|
|
assert.strictEqual(typeof signal2.uid, 'number');
|
|
assert.strictEqual(typeof signal2.triggerAsyncId, 'number');
|
|
|
|
checkInvocations(
|
|
signal1, { init: 1, before: 2, after: 1 },
|
|
'signal1: when second SIGUSR2 handler is set up');
|
|
checkInvocations(
|
|
signal2, { init: 1 },
|
|
'signal2: when second SIGUSR2 handler is setup');
|
|
|
|
exec(`kill -USR2 ${process.pid}`);
|
|
}
|
|
}
|
|
|
|
function onsigusr2Again() {
|
|
clearInterval(interval);
|
|
setImmediate(() => {
|
|
checkInvocations(
|
|
signal1, { init: 1, before: 2, after: 2, destroy: 1 },
|
|
'signal1: when second SIGUSR2 handler is called');
|
|
checkInvocations(
|
|
signal2, { init: 1, before: 1 },
|
|
'signal2: when second SIGUSR2 handler is called');
|
|
});
|
|
}
|
|
|
|
process.on('exit', onexit);
|
|
|
|
function onexit() {
|
|
hooks.disable();
|
|
hooks.sanityCheck('SIGNALWRAP');
|
|
checkInvocations(
|
|
signal1, { init: 1, before: 2, after: 2, destroy: 1 },
|
|
'signal1: when second SIGUSR2 process exits');
|
|
// Second signal not destroyed yet since its event listener is still active
|
|
checkInvocations(
|
|
signal2, { init: 1, before: 1, after: 1 },
|
|
'signal2: when second SIGUSR2 process exits');
|
|
}
|