mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 13:40:37 +00:00

There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
44 lines
1.2 KiB
JavaScript
44 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const initHooks = require('./init-hooks');
|
|
const { checkInvocations } = require('./hook-checks');
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread) {
|
|
common.skip('Worker bootstrapping works differently -> different async IDs');
|
|
}
|
|
|
|
const p = new Promise(common.mustCall(function executor(resolve) {
|
|
resolve(5);
|
|
}));
|
|
|
|
p.then(function afterResolution(val) {
|
|
assert.strictEqual(val, 5);
|
|
return val;
|
|
});
|
|
|
|
// Init hooks after chained promise is created
|
|
const hooks = initHooks();
|
|
hooks._allowNoInit = true;
|
|
hooks.enable();
|
|
|
|
|
|
process.on('exit', function onexit() {
|
|
hooks.disable();
|
|
hooks.sanityCheck('PROMISE');
|
|
|
|
// Because the init event was never emitted the hooks listener doesn't
|
|
// know what the type was. Thus check for Unknown rather than PROMISE.
|
|
const as = hooks.activitiesOfTypes('PROMISE');
|
|
const unknown = hooks.activitiesOfTypes('Unknown');
|
|
assert.strictEqual(as.length, 0);
|
|
assert.strictEqual(unknown.length, 1);
|
|
|
|
const a0 = unknown[0];
|
|
assert.strictEqual(a0.type, 'Unknown');
|
|
assert.strictEqual(typeof a0.uid, 'number');
|
|
checkInvocations(a0, { before: 1, after: 1 }, 'when process exits');
|
|
});
|