mirror of
https://github.com/nodejs/node.git
synced 2025-05-23 02:08:52 +00:00
8c6d1a0686
PR-URL: https://github.com/nodejs/node/pull/21817 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>
78 lines
2.4 KiB
JavaScript
78 lines
2.4 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag variable leak in CatchClauses in IE 8 and earlier
|
|
* @author Ian Christian Myers
|
|
* @deprecated in ESLint v5.1.0
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const astUtils = require("../ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "disallow `catch` clause parameters from shadowing variables in the outer scope",
|
|
category: "Variables",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/rules/no-catch-shadow",
|
|
replacedBy: ["no-shadow"]
|
|
},
|
|
deprecated: true,
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
mutable: "Value of '{{name}}' may be overwritten in IE 8 and earlier."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Helpers
|
|
//--------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Check if the parameters are been shadowed
|
|
* @param {Object} scope current scope
|
|
* @param {string} name parameter name
|
|
* @returns {boolean} True is its been shadowed
|
|
*/
|
|
function paramIsShadowing(scope, name) {
|
|
return astUtils.getVariableByName(scope, name) !== null;
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public API
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
|
|
"CatchClause[param!=null]"(node) {
|
|
let scope = context.getScope();
|
|
|
|
/*
|
|
* When ecmaVersion >= 6, CatchClause creates its own scope
|
|
* so start from one upper scope to exclude the current node
|
|
*/
|
|
if (scope.block === node) {
|
|
scope = scope.upper;
|
|
}
|
|
|
|
if (paramIsShadowing(scope, node.param.name)) {
|
|
context.report({ node, messageId: "mutable", data: { name: node.param.name } });
|
|
}
|
|
}
|
|
};
|
|
|
|
}
|
|
};
|