mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 19:38:23 +00:00
8876ac5c35
Fix some issues introduced/not fixed via https://github.com/nodejs/node/pull/25094: * Init hook is not emitted for a reused HTTPParser * HTTPParser was still used as resource in init hook * type used in init hook was always HTTPINCOMINGMESSAGE even for client requests * some tests have not been adapted to new resource names With this change the async hooks init event is emitted during a call to Initialize() as the type and resource object is available at this time. As a result Initialize() must be called now which could be seen as breaking change even HTTPParser is not part of documented API. It was needed to put the ClientRequest instance into a wrapper object instead passing it directly as async resource otherwise test-domain-multi fails. I think this is because adding an EventEmitter to a Domain adds a property 'domain' and the presence of this changes the context propagation in domains. Besides that tests still refering to resource HTTPParser have been updated/improved. Fixes: https://github.com/nodejs/node/issues/27467 Fixes: https://github.com/nodejs/node/issues/26961 Refs: https://github.com/nodejs/node/pull/25094 PR-URL: https://github.com/nodejs/node/pull/27477 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
63 lines
1.6 KiB
JavaScript
63 lines
1.6 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const Countdown = require('../common/countdown');
|
|
const assert = require('assert');
|
|
const async_hooks = require('async_hooks');
|
|
const http = require('http');
|
|
|
|
// Regression test for https://github.com/nodejs/node/issues/19859.
|
|
// Checks that matching destroys are emitted when creating new/reusing old http
|
|
// parser instances.
|
|
|
|
const N = 50;
|
|
const KEEP_ALIVE = 100;
|
|
|
|
const createdIds = [];
|
|
const destroyedIds = [];
|
|
async_hooks.createHook({
|
|
init: common.mustCallAtLeast((asyncId, type) => {
|
|
if (type === 'HTTPINCOMINGMESSAGE' || type === 'HTTPCLIENTREQUEST') {
|
|
createdIds.push(asyncId);
|
|
}
|
|
}, N),
|
|
destroy: (asyncId) => {
|
|
destroyedIds.push(asyncId);
|
|
}
|
|
}).enable();
|
|
|
|
const server = http.createServer((req, res) => {
|
|
res.end('Hello');
|
|
});
|
|
|
|
const keepAliveAgent = new http.Agent({
|
|
keepAlive: true,
|
|
keepAliveMsecs: KEEP_ALIVE,
|
|
});
|
|
|
|
const countdown = new Countdown(N, () => {
|
|
server.close(() => {
|
|
// Give the server sockets time to close (which will also free their
|
|
// associated parser objects) after the server has been closed.
|
|
setTimeout(() => {
|
|
assert.strictEqual(createdIds.length, 2 * N);
|
|
createdIds.forEach((createdAsyncId) => {
|
|
assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0);
|
|
});
|
|
}, KEEP_ALIVE * 2);
|
|
});
|
|
});
|
|
|
|
server.listen(0, function() {
|
|
for (let i = 0; i < N; ++i) {
|
|
(function makeRequest() {
|
|
http.get({
|
|
port: server.address().port,
|
|
agent: keepAliveAgent
|
|
}, function(res) {
|
|
countdown.dec();
|
|
res.resume();
|
|
});
|
|
})();
|
|
}
|
|
});
|