mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 18:37:06 +00:00
8876ac5c35
Fix some issues introduced/not fixed via https://github.com/nodejs/node/pull/25094: * Init hook is not emitted for a reused HTTPParser * HTTPParser was still used as resource in init hook * type used in init hook was always HTTPINCOMINGMESSAGE even for client requests * some tests have not been adapted to new resource names With this change the async hooks init event is emitted during a call to Initialize() as the type and resource object is available at this time. As a result Initialize() must be called now which could be seen as breaking change even HTTPParser is not part of documented API. It was needed to put the ClientRequest instance into a wrapper object instead passing it directly as async resource otherwise test-domain-multi fails. I think this is because adding an EventEmitter to a Domain adds a property 'domain' and the presence of this changes the context propagation in domains. Besides that tests still refering to resource HTTPParser have been updated/improved. Fixes: https://github.com/nodejs/node/issues/27467 Fixes: https://github.com/nodejs/node/issues/26961 Refs: https://github.com/nodejs/node/pull/25094 PR-URL: https://github.com/nodejs/node/pull/27477 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
55 lines
1.4 KiB
JavaScript
55 lines
1.4 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const tick = require('../common/tick');
|
|
const initHooks = require('./init-hooks');
|
|
const { checkInvocations } = require('./hook-checks');
|
|
|
|
const hooks = initHooks();
|
|
hooks.enable();
|
|
|
|
const { HTTPParser } = require('_http_common');
|
|
|
|
const REQUEST = HTTPParser.REQUEST;
|
|
|
|
const kOnHeadersComplete = HTTPParser.kOnHeadersComplete | 0;
|
|
|
|
const request = Buffer.from(
|
|
'GET /hello HTTP/1.1\r\n\r\n'
|
|
);
|
|
|
|
const parser = new HTTPParser();
|
|
parser.initialize(REQUEST, {});
|
|
const as = hooks.activitiesOfTypes('HTTPINCOMINGMESSAGE');
|
|
const httpparser = as[0];
|
|
|
|
assert.strictEqual(as.length, 1);
|
|
assert.strictEqual(typeof httpparser.uid, 'number');
|
|
assert.strictEqual(typeof httpparser.triggerAsyncId, 'number');
|
|
checkInvocations(httpparser, { init: 1 }, 'when created new Httphttpparser');
|
|
|
|
parser[kOnHeadersComplete] = common.mustCall(onheadersComplete);
|
|
parser.execute(request, 0, request.length);
|
|
|
|
function onheadersComplete() {
|
|
checkInvocations(httpparser, { init: 1, before: 1 },
|
|
'when onheadersComplete called');
|
|
tick(1, common.mustCall(tick1));
|
|
}
|
|
|
|
function tick1() {
|
|
parser.close();
|
|
tick(1);
|
|
}
|
|
|
|
process.on('exit', onexit);
|
|
|
|
function onexit() {
|
|
hooks.disable();
|
|
hooks.sanityCheck('HTTPINCOMINGMESSAGE');
|
|
checkInvocations(httpparser, { init: 1, before: 1, after: 1, destroy: 1 },
|
|
'when process exits');
|
|
}
|