mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 23:56:58 +00:00
8741e3c750
async_hooks init callback will be triggered when promise newly created, in previous version, the parent promise which pass from chrome V8 PromiseHook is ignored, so we can't tell the promise is a pure new promise or a chained promise. In this commit, we use the parent promise's id as triggerId to trigger the init callback. Fixes: https://github.com/nodejs/node/issues/13302 PR-URL: https://github.com/nodejs/node/pull/13367 Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
53 lines
1.7 KiB
JavaScript
53 lines
1.7 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const initHooks = require('./init-hooks');
|
|
const { checkInvocations } = require('./hook-checks');
|
|
|
|
const hooks = initHooks();
|
|
|
|
hooks.enable();
|
|
|
|
const p = (new Promise(common.mustCall(executor)));
|
|
p.then(afterresolution);
|
|
|
|
function executor(resolve, reject) {
|
|
const as = hooks.activitiesOfTypes('PROMISE');
|
|
assert.strictEqual(as.length, 1, 'one activities');
|
|
const a = as[0];
|
|
checkInvocations(a, { init: 1 }, 'while in promise executor');
|
|
resolve(5);
|
|
}
|
|
|
|
function afterresolution(val) {
|
|
assert.strictEqual(val, 5);
|
|
const as = hooks.activitiesOfTypes('PROMISE');
|
|
assert.strictEqual(as.length, 2, 'two activities');
|
|
checkInvocations(as[0], { init: 1 }, 'after resolution parent promise');
|
|
checkInvocations(as[1], { init: 1, before: 1 },
|
|
'after resolution child promise');
|
|
}
|
|
|
|
process.on('exit', onexit);
|
|
function onexit() {
|
|
hooks.disable();
|
|
hooks.sanityCheck('PROMISE');
|
|
|
|
const as = hooks.activitiesOfTypes('PROMISE');
|
|
assert.strictEqual(as.length, 2, 'two activities');
|
|
|
|
const a0 = as[0];
|
|
assert.strictEqual(a0.type, 'PROMISE', 'promise request');
|
|
assert.strictEqual(typeof a0.uid, 'number', 'uid is a number');
|
|
assert.strictEqual(a0.triggerId, 1, 'parent uid 1');
|
|
checkInvocations(a0, { init: 1 }, 'when process exits');
|
|
|
|
const a1 = as[1];
|
|
assert.strictEqual(a1.type, 'PROMISE', 'promise request');
|
|
assert.strictEqual(typeof a1.uid, 'number', 'uid is a number');
|
|
assert.strictEqual(a1.triggerId, a0.uid);
|
|
// We expect a destroy hook as well but we cannot guarentee predictable gc.
|
|
checkInvocations(a1, { init: 1, before: 1, after: 1 }, 'when process exits');
|
|
}
|