mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 07:19:19 +00:00
8700d89306
Whether and when a socket is destroyed or not after a timeout is up to the user. This leaves an edge case where a socket that has emitted 'timeout' might be re-used from the free pool. Even if destroy is called on the socket, it won't be removed from the freelist until 'close' which can happen several ticks later. Sockets are removed from the free list on the 'close' event. However, there is a delay between calling destroy() and 'close' being emitted. This means that it possible for a socket that has been destroyed to be re-used from the free list, causing unexpected failures. PR-URL: https://github.com/nodejs/node/pull/32000 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
95 lines
2.5 KiB
JavaScript
95 lines
2.5 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
|
|
{
|
|
// Ensure reuse of successful sockets.
|
|
|
|
const agent = new http.Agent({ keepAlive: true });
|
|
|
|
const server = http.createServer((req, res) => {
|
|
res.end();
|
|
});
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
let socket;
|
|
http.get({ port: server.address().port, agent })
|
|
.on('response', common.mustCall((res) => {
|
|
socket = res.socket;
|
|
assert(socket);
|
|
res.resume();
|
|
socket.on('free', common.mustCall(() => {
|
|
http.get({ port: server.address().port, agent })
|
|
.on('response', common.mustCall((res) => {
|
|
assert.strictEqual(socket, res.socket);
|
|
assert(socket);
|
|
agent.destroy();
|
|
server.close();
|
|
}));
|
|
}));
|
|
}));
|
|
}));
|
|
}
|
|
|
|
{
|
|
// Ensure that timeouted sockets are not reused.
|
|
|
|
const agent = new http.Agent({ keepAlive: true, timeout: 50 });
|
|
|
|
const server = http.createServer((req, res) => {
|
|
res.end();
|
|
});
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
http.get({ port: server.address().port, agent })
|
|
.on('response', common.mustCall((res) => {
|
|
const socket = res.socket;
|
|
assert(socket);
|
|
res.resume();
|
|
socket.on('free', common.mustCall(() => {
|
|
socket.on('timeout', common.mustCall(() => {
|
|
http.get({ port: server.address().port, agent })
|
|
.on('response', common.mustCall((res) => {
|
|
assert.notStrictEqual(socket, res.socket);
|
|
assert.strictEqual(socket.destroyed, true);
|
|
agent.destroy();
|
|
server.close();
|
|
}));
|
|
}));
|
|
}));
|
|
}));
|
|
}));
|
|
}
|
|
|
|
{
|
|
// Ensure that destroyed sockets are not reused.
|
|
|
|
const agent = new http.Agent({ keepAlive: true });
|
|
|
|
const server = http.createServer((req, res) => {
|
|
res.end();
|
|
});
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
let socket;
|
|
http.get({ port: server.address().port, agent })
|
|
.on('response', common.mustCall((res) => {
|
|
socket = res.socket;
|
|
assert(socket);
|
|
res.resume();
|
|
socket.on('free', common.mustCall(() => {
|
|
socket.destroy();
|
|
http.get({ port: server.address().port, agent })
|
|
.on('response', common.mustCall((res) => {
|
|
assert.notStrictEqual(socket, res.socket);
|
|
assert(socket);
|
|
agent.destroy();
|
|
server.close();
|
|
}));
|
|
}));
|
|
}));
|
|
}));
|
|
}
|