mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 08:00:26 +00:00
85ab4a5f12
Several changes:
* Soft-Deprecate Buffer() constructors
* Add `Buffer.from()`, `Buffer.alloc()`, and `Buffer.allocUnsafe()`
* Add `--zero-fill-buffers` command line option
* Add byteOffset and length to `new Buffer(arrayBuffer)` constructor
* buffer.fill('') previously had no effect, now zero-fills
* Update the docs
PR-URL: https://github.com/nodejs/node/pull/4682
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
88 lines
1.9 KiB
JavaScript
88 lines
1.9 KiB
JavaScript
'use strict';
|
|
// Run this program with valgrind or efence with --expose_gc to expose the
|
|
// problem.
|
|
|
|
// Flags: --expose_gc
|
|
|
|
require('../common');
|
|
var assert = require('assert');
|
|
var HTTPParser = process.binding('http_parser').HTTPParser;
|
|
|
|
var kOnHeaders = HTTPParser.kOnHeaders | 0;
|
|
var kOnHeadersComplete = HTTPParser.kOnHeadersComplete | 0;
|
|
var kOnBody = HTTPParser.kOnBody | 0;
|
|
var kOnMessageComplete = HTTPParser.kOnMessageComplete | 0;
|
|
|
|
var headersComplete = 0;
|
|
var messagesComplete = 0;
|
|
|
|
function flushPool() {
|
|
Buffer.allocUnsafe(Buffer.poolSize - 1);
|
|
gc();
|
|
}
|
|
|
|
function demoBug(part1, part2) {
|
|
flushPool();
|
|
|
|
var parser = new HTTPParser('REQUEST');
|
|
|
|
parser.headers = [];
|
|
parser.url = '';
|
|
|
|
parser[kOnHeaders] = function(headers, url) {
|
|
parser.headers = parser.headers.concat(headers);
|
|
parser.url += url;
|
|
};
|
|
|
|
parser[kOnHeadersComplete] = function(info) {
|
|
headersComplete++;
|
|
console.log('url', info.url);
|
|
};
|
|
|
|
parser[kOnBody] = function(b, start, len) { };
|
|
|
|
parser[kOnMessageComplete] = function() {
|
|
messagesComplete++;
|
|
};
|
|
|
|
|
|
// We use a function to eliminate references to the Buffer b
|
|
// We want b to be GCed. The parser will hold a bad reference to it.
|
|
(function() {
|
|
var b = Buffer.from(part1);
|
|
flushPool();
|
|
|
|
console.log('parse the first part of the message');
|
|
parser.execute(b, 0, b.length);
|
|
})();
|
|
|
|
flushPool();
|
|
|
|
(function() {
|
|
var b = Buffer.from(part2);
|
|
|
|
console.log('parse the second part of the message');
|
|
parser.execute(b, 0, b.length);
|
|
parser.finish();
|
|
})();
|
|
|
|
flushPool();
|
|
}
|
|
|
|
|
|
demoBug('POST /1', '/22 HTTP/1.1\r\n' +
|
|
'Content-Type: text/plain\r\n' +
|
|
'Content-Length: 4\r\n\r\n' +
|
|
'pong');
|
|
|
|
demoBug('POST /1/22 HTTP/1.1\r\n' +
|
|
'Content-Type: tex', 't/plain\r\n' +
|
|
'Content-Length: 4\r\n\r\n' +
|
|
'pong');
|
|
|
|
process.on('exit', function() {
|
|
assert.equal(2, headersComplete);
|
|
assert.equal(2, messagesComplete);
|
|
console.log('done!');
|
|
});
|