mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 11:08:24 +00:00
849aaaeeb0
This reverts commit b994b8eff6.
This caused regressions in ecosystem code. While the change originally
was semver-major and could be postponed until after Node.js 10,
I think reverting it is a good choice at this point.
Also, I personally do not think defaulting to a shallow inspect
is a bad thing at all – quite the opposite: It makes `util.inspect()`
give an overview of an object, rather than providing a full
display of its contents. Changing the `depth` default to infinity
fundamentally changed the role that `util.inspect()` plays,
and makes output much more verbose and thus at times unusable
for `console.log()`-style debugging.
PR-URL: https://github.com/nodejs/node/pull/20017
Fixes: https://github.com/nodejs/node/issues/19405
Refs: https://github.com/nodejs/node/pull/17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
33 lines
781 B
JavaScript
33 lines
781 B
JavaScript
// Flags: --expose_internals
|
|
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const BufferList = require('internal/streams/buffer_list');
|
|
|
|
// Test empty buffer list.
|
|
const emptyList = new BufferList();
|
|
|
|
emptyList.shift();
|
|
assert.deepStrictEqual(emptyList, new BufferList());
|
|
|
|
assert.strictEqual(emptyList.join(','), '');
|
|
|
|
assert.deepStrictEqual(emptyList.concat(0), Buffer.alloc(0));
|
|
|
|
const buf = Buffer.from('foo');
|
|
|
|
// Test buffer list with one element.
|
|
const list = new BufferList();
|
|
list.push(buf);
|
|
|
|
const copy = list.concat(3);
|
|
|
|
assert.notStrictEqual(copy, buf);
|
|
assert.deepStrictEqual(copy, buf);
|
|
|
|
assert.strictEqual(list.join(','), 'foo');
|
|
|
|
const shifted = list.shift();
|
|
assert.strictEqual(shifted, buf);
|
|
assert.deepStrictEqual(list, new BufferList());
|