mirror of
https://github.com/nodejs/node.git
synced 2025-05-20 17:13:10 +00:00

Enable linting for the test directory. A number of changes was made so all tests conform the current rules used by lib and src directories. The only exception for tests is that unreachable (dead) code is allowed. test-fs-non-number-arguments-throw had to be excluded from the changes because of a weird issue on Windows CI. PR-URL: https://github.com/nodejs/io.js/pull/1721 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
416 lines
16 KiB
JavaScript
416 lines
16 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
var path = require('path');
|
|
|
|
var isWindows = process.platform === 'win32';
|
|
|
|
var f = __filename;
|
|
|
|
assert.equal(path.basename(f), 'test-path.js');
|
|
assert.equal(path.basename(f, '.js'), 'test-path');
|
|
assert.equal(path.basename(''), '');
|
|
assert.equal(path.basename('/dir/basename.ext'), 'basename.ext');
|
|
assert.equal(path.basename('/basename.ext'), 'basename.ext');
|
|
assert.equal(path.basename('basename.ext'), 'basename.ext');
|
|
assert.equal(path.basename('basename.ext/'), 'basename.ext');
|
|
assert.equal(path.basename('basename.ext//'), 'basename.ext');
|
|
|
|
// On Windows a backslash acts as a path separator.
|
|
assert.equal(path.win32.basename('\\dir\\basename.ext'), 'basename.ext');
|
|
assert.equal(path.win32.basename('\\basename.ext'), 'basename.ext');
|
|
assert.equal(path.win32.basename('basename.ext'), 'basename.ext');
|
|
assert.equal(path.win32.basename('basename.ext\\'), 'basename.ext');
|
|
assert.equal(path.win32.basename('basename.ext\\\\'), 'basename.ext');
|
|
|
|
// On unix a backslash is just treated as any other character.
|
|
assert.equal(path.posix.basename('\\dir\\basename.ext'), '\\dir\\basename.ext');
|
|
assert.equal(path.posix.basename('\\basename.ext'), '\\basename.ext');
|
|
assert.equal(path.posix.basename('basename.ext'), 'basename.ext');
|
|
assert.equal(path.posix.basename('basename.ext\\'), 'basename.ext\\');
|
|
assert.equal(path.posix.basename('basename.ext\\\\'), 'basename.ext\\\\');
|
|
|
|
// POSIX filenames may include control characters
|
|
// c.f. http://www.dwheeler.com/essays/fixing-unix-linux-filenames.html
|
|
if (!isWindows) {
|
|
var controlCharFilename = 'Icon' + String.fromCharCode(13);
|
|
assert.equal(path.basename('/a/b/' + controlCharFilename),
|
|
controlCharFilename);
|
|
}
|
|
|
|
assert.equal(path.extname(f), '.js');
|
|
|
|
assert.equal(path.dirname(f).substr(-13),
|
|
isWindows ? 'test\\parallel' : 'test/parallel');
|
|
assert.equal(path.dirname('/a/b/'), '/a');
|
|
assert.equal(path.dirname('/a/b'), '/a');
|
|
assert.equal(path.dirname('/a'), '/');
|
|
assert.equal(path.dirname(''), '.');
|
|
assert.equal(path.dirname('/'), '/');
|
|
assert.equal(path.dirname('////'), '/');
|
|
|
|
assert.equal(path.win32.dirname('c:\\'), 'c:\\');
|
|
assert.equal(path.win32.dirname('c:\\foo'), 'c:\\');
|
|
assert.equal(path.win32.dirname('c:\\foo\\'), 'c:\\');
|
|
assert.equal(path.win32.dirname('c:\\foo\\bar'), 'c:\\foo');
|
|
assert.equal(path.win32.dirname('c:\\foo\\bar\\'), 'c:\\foo');
|
|
assert.equal(path.win32.dirname('c:\\foo\\bar\\baz'), 'c:\\foo\\bar');
|
|
assert.equal(path.win32.dirname('\\'), '\\');
|
|
assert.equal(path.win32.dirname('\\foo'), '\\');
|
|
assert.equal(path.win32.dirname('\\foo\\'), '\\');
|
|
assert.equal(path.win32.dirname('\\foo\\bar'), '\\foo');
|
|
assert.equal(path.win32.dirname('\\foo\\bar\\'), '\\foo');
|
|
assert.equal(path.win32.dirname('\\foo\\bar\\baz'), '\\foo\\bar');
|
|
assert.equal(path.win32.dirname('c:'), 'c:');
|
|
assert.equal(path.win32.dirname('c:foo'), 'c:');
|
|
assert.equal(path.win32.dirname('c:foo\\'), 'c:');
|
|
assert.equal(path.win32.dirname('c:foo\\bar'), 'c:foo');
|
|
assert.equal(path.win32.dirname('c:foo\\bar\\'), 'c:foo');
|
|
assert.equal(path.win32.dirname('c:foo\\bar\\baz'), 'c:foo\\bar');
|
|
assert.equal(path.win32.dirname('\\\\unc\\share'), '\\\\unc\\share');
|
|
assert.equal(path.win32.dirname('\\\\unc\\share\\foo'), '\\\\unc\\share\\');
|
|
assert.equal(path.win32.dirname('\\\\unc\\share\\foo\\'), '\\\\unc\\share\\');
|
|
assert.equal(path.win32.dirname('\\\\unc\\share\\foo\\bar'),
|
|
'\\\\unc\\share\\foo');
|
|
assert.equal(path.win32.dirname('\\\\unc\\share\\foo\\bar\\'),
|
|
'\\\\unc\\share\\foo');
|
|
assert.equal(path.win32.dirname('\\\\unc\\share\\foo\\bar\\baz'),
|
|
'\\\\unc\\share\\foo\\bar');
|
|
|
|
|
|
assert.equal(path.extname(''), '');
|
|
assert.equal(path.extname('/path/to/file'), '');
|
|
assert.equal(path.extname('/path/to/file.ext'), '.ext');
|
|
assert.equal(path.extname('/path.to/file.ext'), '.ext');
|
|
assert.equal(path.extname('/path.to/file'), '');
|
|
assert.equal(path.extname('/path.to/.file'), '');
|
|
assert.equal(path.extname('/path.to/.file.ext'), '.ext');
|
|
assert.equal(path.extname('/path/to/f.ext'), '.ext');
|
|
assert.equal(path.extname('/path/to/..ext'), '.ext');
|
|
assert.equal(path.extname('file'), '');
|
|
assert.equal(path.extname('file.ext'), '.ext');
|
|
assert.equal(path.extname('.file'), '');
|
|
assert.equal(path.extname('.file.ext'), '.ext');
|
|
assert.equal(path.extname('/file'), '');
|
|
assert.equal(path.extname('/file.ext'), '.ext');
|
|
assert.equal(path.extname('/.file'), '');
|
|
assert.equal(path.extname('/.file.ext'), '.ext');
|
|
assert.equal(path.extname('.path/file.ext'), '.ext');
|
|
assert.equal(path.extname('file.ext.ext'), '.ext');
|
|
assert.equal(path.extname('file.'), '.');
|
|
assert.equal(path.extname('.'), '');
|
|
assert.equal(path.extname('./'), '');
|
|
assert.equal(path.extname('.file.ext'), '.ext');
|
|
assert.equal(path.extname('.file'), '');
|
|
assert.equal(path.extname('.file.'), '.');
|
|
assert.equal(path.extname('.file..'), '.');
|
|
assert.equal(path.extname('..'), '');
|
|
assert.equal(path.extname('../'), '');
|
|
assert.equal(path.extname('..file.ext'), '.ext');
|
|
assert.equal(path.extname('..file'), '.file');
|
|
assert.equal(path.extname('..file.'), '.');
|
|
assert.equal(path.extname('..file..'), '.');
|
|
assert.equal(path.extname('...'), '.');
|
|
assert.equal(path.extname('...ext'), '.ext');
|
|
assert.equal(path.extname('....'), '.');
|
|
assert.equal(path.extname('file.ext/'), '.ext');
|
|
assert.equal(path.extname('file.ext//'), '.ext');
|
|
assert.equal(path.extname('file/'), '');
|
|
assert.equal(path.extname('file//'), '');
|
|
assert.equal(path.extname('file./'), '.');
|
|
assert.equal(path.extname('file.//'), '.');
|
|
|
|
// On windows, backspace is a path separator.
|
|
assert.equal(path.win32.extname('.\\'), '');
|
|
assert.equal(path.win32.extname('..\\'), '');
|
|
assert.equal(path.win32.extname('file.ext\\'), '.ext');
|
|
assert.equal(path.win32.extname('file.ext\\\\'), '.ext');
|
|
assert.equal(path.win32.extname('file\\'), '');
|
|
assert.equal(path.win32.extname('file\\\\'), '');
|
|
assert.equal(path.win32.extname('file.\\'), '.');
|
|
assert.equal(path.win32.extname('file.\\\\'), '.');
|
|
|
|
// On unix, backspace is a valid name component like any other character.
|
|
assert.equal(path.posix.extname('.\\'), '');
|
|
assert.equal(path.posix.extname('..\\'), '.\\');
|
|
assert.equal(path.posix.extname('file.ext\\'), '.ext\\');
|
|
assert.equal(path.posix.extname('file.ext\\\\'), '.ext\\\\');
|
|
assert.equal(path.posix.extname('file\\'), '');
|
|
assert.equal(path.posix.extname('file\\\\'), '');
|
|
assert.equal(path.posix.extname('file.\\'), '.\\');
|
|
assert.equal(path.posix.extname('file.\\\\'), '.\\\\');
|
|
|
|
// path.join tests
|
|
var failures = [];
|
|
var joinTests =
|
|
// arguments result
|
|
[[['.', 'x/b', '..', '/b/c.js'], 'x/b/c.js'],
|
|
[['/.', 'x/b', '..', '/b/c.js'], '/x/b/c.js'],
|
|
[['/foo', '../../../bar'], '/bar'],
|
|
[['foo', '../../../bar'], '../../bar'],
|
|
[['foo/', '../../../bar'], '../../bar'],
|
|
[['foo/x', '../../../bar'], '../bar'],
|
|
[['foo/x', './bar'], 'foo/x/bar'],
|
|
[['foo/x/', './bar'], 'foo/x/bar'],
|
|
[['foo/x/', '.', 'bar'], 'foo/x/bar'],
|
|
[['./'], './'],
|
|
[['.', './'], './'],
|
|
[['.', '.', '.'], '.'],
|
|
[['.', './', '.'], '.'],
|
|
[['.', '/./', '.'], '.'],
|
|
[['.', '/////./', '.'], '.'],
|
|
[['.'], '.'],
|
|
[['', '.'], '.'],
|
|
[['', 'foo'], 'foo'],
|
|
[['foo', '/bar'], 'foo/bar'],
|
|
[['', '/foo'], '/foo'],
|
|
[['', '', '/foo'], '/foo'],
|
|
[['', '', 'foo'], 'foo'],
|
|
[['foo', ''], 'foo'],
|
|
[['foo/', ''], 'foo/'],
|
|
[['foo', '', '/bar'], 'foo/bar'],
|
|
[['./', '..', '/foo'], '../foo'],
|
|
[['./', '..', '..', '/foo'], '../../foo'],
|
|
[['.', '..', '..', '/foo'], '../../foo'],
|
|
[['', '..', '..', '/foo'], '../../foo'],
|
|
[['/'], '/'],
|
|
[['/', '.'], '/'],
|
|
[['/', '..'], '/'],
|
|
[['/', '..', '..'], '/'],
|
|
[[''], '.'],
|
|
[['', ''], '.'],
|
|
[[' /foo'], ' /foo'],
|
|
[[' ', 'foo'], ' /foo'],
|
|
[[' ', '.'], ' '],
|
|
[[' ', '/'], ' /'],
|
|
[[' ', ''], ' '],
|
|
[['/', 'foo'], '/foo'],
|
|
[['/', '/foo'], '/foo'],
|
|
[['/', '//foo'], '/foo'],
|
|
[['/', '', '/foo'], '/foo'],
|
|
[['', '/', 'foo'], '/foo'],
|
|
[['', '/', '/foo'], '/foo']
|
|
];
|
|
|
|
// Windows-specific join tests
|
|
if (isWindows) {
|
|
joinTests = joinTests.concat(
|
|
[// UNC path expected
|
|
[['//foo/bar'], '//foo/bar/'],
|
|
[['\\/foo/bar'], '//foo/bar/'],
|
|
[['\\\\foo/bar'], '//foo/bar/'],
|
|
// UNC path expected - server and share separate
|
|
[['//foo', 'bar'], '//foo/bar/'],
|
|
[['//foo/', 'bar'], '//foo/bar/'],
|
|
[['//foo', '/bar'], '//foo/bar/'],
|
|
// UNC path expected - questionable
|
|
[['//foo', '', 'bar'], '//foo/bar/'],
|
|
[['//foo/', '', 'bar'], '//foo/bar/'],
|
|
[['//foo/', '', '/bar'], '//foo/bar/'],
|
|
// UNC path expected - even more questionable
|
|
[['', '//foo', 'bar'], '//foo/bar/'],
|
|
[['', '//foo/', 'bar'], '//foo/bar/'],
|
|
[['', '//foo/', '/bar'], '//foo/bar/'],
|
|
// No UNC path expected (no double slash in first component)
|
|
[['\\', 'foo/bar'], '/foo/bar'],
|
|
[['\\', '/foo/bar'], '/foo/bar'],
|
|
[['', '/', '/foo/bar'], '/foo/bar'],
|
|
// No UNC path expected (no non-slashes in first component - questionable)
|
|
[['//', 'foo/bar'], '/foo/bar'],
|
|
[['//', '/foo/bar'], '/foo/bar'],
|
|
[['\\\\', '/', '/foo/bar'], '/foo/bar'],
|
|
[['//'], '/'],
|
|
// No UNC path expected (share name missing - questionable).
|
|
[['//foo'], '/foo'],
|
|
[['//foo/'], '/foo/'],
|
|
[['//foo', '/'], '/foo/'],
|
|
[['//foo', '', '/'], '/foo/'],
|
|
// No UNC path expected (too many leading slashes - questionable)
|
|
[['///foo/bar'], '/foo/bar'],
|
|
[['////foo', 'bar'], '/foo/bar'],
|
|
[['\\\\\\/foo/bar'], '/foo/bar'],
|
|
// Drive-relative vs drive-absolute paths. This merely describes the
|
|
// status quo, rather than being obviously right
|
|
[['c:'], 'c:.'],
|
|
[['c:.'], 'c:.'],
|
|
[['c:', ''], 'c:.'],
|
|
[['', 'c:'], 'c:.'],
|
|
[['c:.', '/'], 'c:./'],
|
|
[['c:.', 'file'], 'c:file'],
|
|
[['c:', '/'], 'c:/'],
|
|
[['c:', 'file'], 'c:/file']
|
|
]);
|
|
}
|
|
|
|
// Run the join tests.
|
|
joinTests.forEach(function(test) {
|
|
var actual = path.join.apply(path, test[0]);
|
|
var expected = isWindows ? test[1].replace(/\//g, '\\') : test[1];
|
|
var message = 'path.join(' + test[0].map(JSON.stringify).join(',') + ')' +
|
|
'\n expect=' + JSON.stringify(expected) +
|
|
'\n actual=' + JSON.stringify(actual);
|
|
if (actual !== expected) failures.push('\n' + message);
|
|
// assert.equal(actual, expected, message);
|
|
});
|
|
assert.equal(failures.length, 0, failures.join(''));
|
|
|
|
// Test thrown TypeErrors
|
|
var typeErrorTests = [true, false, 7, null, {}, undefined, [], NaN];
|
|
|
|
function fail(fn) {
|
|
var args = Array.prototype.slice.call(arguments, 1);
|
|
|
|
assert.throws(function() {
|
|
fn.apply(null, args);
|
|
}, TypeError);
|
|
}
|
|
|
|
typeErrorTests.forEach(function(test) {
|
|
fail(path.join, test);
|
|
fail(path.resolve, test);
|
|
fail(path.normalize, test);
|
|
fail(path.isAbsolute, test);
|
|
fail(path.relative, test, 'foo');
|
|
fail(path.relative, 'foo', test);
|
|
fail(path.parse, test);
|
|
|
|
// These methods should throw a TypeError, but do not for backwards
|
|
// compatibility. Uncommenting these lines in the future should be a goal.
|
|
// fail(path.dirname, test);
|
|
// fail(path.basename, test);
|
|
// fail(path.extname, test);
|
|
|
|
// undefined is a valid value as the second argument to basename
|
|
if (test !== undefined) {
|
|
fail(path.basename, 'foo', test);
|
|
}
|
|
});
|
|
|
|
|
|
// path normalize tests
|
|
assert.equal(path.win32.normalize('./fixtures///b/../b/c.js'),
|
|
'fixtures\\b\\c.js');
|
|
assert.equal(path.win32.normalize('/foo/../../../bar'), '\\bar');
|
|
assert.equal(path.win32.normalize('a//b//../b'), 'a\\b');
|
|
assert.equal(path.win32.normalize('a//b//./c'), 'a\\b\\c');
|
|
assert.equal(path.win32.normalize('a//b//.'), 'a\\b');
|
|
assert.equal(path.win32.normalize('//server/share/dir/file.ext'),
|
|
'\\\\server\\share\\dir\\file.ext');
|
|
|
|
assert.equal(path.posix.normalize('./fixtures///b/../b/c.js'),
|
|
'fixtures/b/c.js');
|
|
assert.equal(path.posix.normalize('/foo/../../../bar'), '/bar');
|
|
assert.equal(path.posix.normalize('a//b//../b'), 'a/b');
|
|
assert.equal(path.posix.normalize('a//b//./c'), 'a/b/c');
|
|
assert.equal(path.posix.normalize('a//b//.'), 'a/b');
|
|
|
|
// path.resolve tests
|
|
if (isWindows) {
|
|
// windows
|
|
var resolveTests =
|
|
// arguments result
|
|
[[['c:/blah\\blah', 'd:/games', 'c:../a'], 'c:\\blah\\a'],
|
|
[['c:/ignore', 'd:\\a/b\\c/d', '\\e.exe'], 'd:\\e.exe'],
|
|
[['c:/ignore', 'c:/some/file'], 'c:\\some\\file'],
|
|
[['d:/ignore', 'd:some/dir//'], 'd:\\ignore\\some\\dir'],
|
|
[['.'], process.cwd()],
|
|
[['//server/share', '..', 'relative\\'], '\\\\server\\share\\relative'],
|
|
[['c:/', '//'], 'c:\\'],
|
|
[['c:/', '//dir'], 'c:\\dir'],
|
|
[['c:/', '//server/share'], '\\\\server\\share\\'],
|
|
[['c:/', '//server//share'], '\\\\server\\share\\'],
|
|
[['c:/', '///some//dir'], 'c:\\some\\dir']
|
|
];
|
|
} else {
|
|
// Posix
|
|
var resolveTests =
|
|
// arguments result
|
|
[[['/var/lib', '../', 'file/'], '/var/file'],
|
|
[['/var/lib', '/../', 'file/'], '/file'],
|
|
[['a/b/c/', '../../..'], process.cwd()],
|
|
[['.'], process.cwd()],
|
|
[['/some/dir', '.', '/absolute/'], '/absolute']];
|
|
}
|
|
var failures = [];
|
|
resolveTests.forEach(function(test) {
|
|
var actual = path.resolve.apply(path, test[0]);
|
|
var expected = test[1];
|
|
var message = 'path.resolve(' + test[0].map(JSON.stringify).join(',') + ')' +
|
|
'\n expect=' + JSON.stringify(expected) +
|
|
'\n actual=' + JSON.stringify(actual);
|
|
if (actual !== expected) failures.push('\n' + message);
|
|
// assert.equal(actual, expected, message);
|
|
});
|
|
assert.equal(failures.length, 0, failures.join(''));
|
|
|
|
// path.isAbsolute tests
|
|
assert.equal(path.win32.isAbsolute('//server/file'), true);
|
|
assert.equal(path.win32.isAbsolute('\\\\server\\file'), true);
|
|
assert.equal(path.win32.isAbsolute('C:/Users/'), true);
|
|
assert.equal(path.win32.isAbsolute('C:\\Users\\'), true);
|
|
assert.equal(path.win32.isAbsolute('C:cwd/another'), false);
|
|
assert.equal(path.win32.isAbsolute('C:cwd\\another'), false);
|
|
assert.equal(path.win32.isAbsolute('directory/directory'), false);
|
|
assert.equal(path.win32.isAbsolute('directory\\directory'), false);
|
|
|
|
assert.equal(path.posix.isAbsolute('/home/foo'), true);
|
|
assert.equal(path.posix.isAbsolute('/home/foo/..'), true);
|
|
assert.equal(path.posix.isAbsolute('bar/'), false);
|
|
assert.equal(path.posix.isAbsolute('./baz'), false);
|
|
|
|
// path.relative tests
|
|
if (isWindows) {
|
|
// windows
|
|
var relativeTests =
|
|
// arguments result
|
|
[['c:/blah\\blah', 'd:/games', 'd:\\games'],
|
|
['c:/aaaa/bbbb', 'c:/aaaa', '..'],
|
|
['c:/aaaa/bbbb', 'c:/cccc', '..\\..\\cccc'],
|
|
['c:/aaaa/bbbb', 'c:/aaaa/bbbb', ''],
|
|
['c:/aaaa/bbbb', 'c:/aaaa/cccc', '..\\cccc'],
|
|
['c:/aaaa/', 'c:/aaaa/cccc', 'cccc'],
|
|
['c:/', 'c:\\aaaa\\bbbb', 'aaaa\\bbbb'],
|
|
['c:/aaaa/bbbb', 'd:\\', 'd:\\']];
|
|
} else {
|
|
// posix
|
|
var relativeTests =
|
|
// arguments result
|
|
[['/var/lib', '/var', '..'],
|
|
['/var/lib', '/bin', '../../bin'],
|
|
['/var/lib', '/var/lib', ''],
|
|
['/var/lib', '/var/apache', '../apache'],
|
|
['/var/', '/var/lib', 'lib'],
|
|
['/', '/var/lib', 'var/lib']];
|
|
}
|
|
var failures = [];
|
|
relativeTests.forEach(function(test) {
|
|
var actual = path.relative(test[0], test[1]);
|
|
var expected = test[2];
|
|
var message = 'path.relative(' +
|
|
test.slice(0, 2).map(JSON.stringify).join(',') +
|
|
')' +
|
|
'\n expect=' + JSON.stringify(expected) +
|
|
'\n actual=' + JSON.stringify(actual);
|
|
if (actual !== expected) failures.push('\n' + message);
|
|
});
|
|
assert.equal(failures.length, 0, failures.join(''));
|
|
|
|
// windows
|
|
assert.equal(path.win32.sep, '\\');
|
|
// posix
|
|
assert.equal(path.posix.sep, '/');
|
|
|
|
// path.delimiter tests
|
|
// windows
|
|
assert.equal(path.win32.delimiter, ';');
|
|
|
|
// posix
|
|
assert.equal(path.posix.delimiter, ':');
|
|
|
|
|
|
if (isWindows)
|
|
assert.deepEqual(path, path.win32, 'should be win32 path module');
|
|
else
|
|
assert.deepEqual(path, path.posix, 'should be posix path module');
|